Turn on scope validation by default

Question

Turn on scope validation by default

danroth27 opened this issue 8 years ago · 7 comments

danroth27 commented 8 years ago

For 2.0 we should consider turning on scope validation by default.

Answer 1 · 2017-02-14T15:14:57.000Z

@pakrym before we turn this on by default need to look at the performance impact.

Answer 2 · 2017-03-12T08:25:12.000Z

Here's results from a benchmark I've added.

                       Method |        Mean |    StdErr |     StdDev |        Op/s | Scaled | Scaled-StdDev |  Gen 0 | Allocated |
----------------------------- |------------ |---------- |----------- |------------ |------- |-------------- |------- |---------- |
                    Transient |  43.5473 ns | 0.4130 ns |  2.2620 ns | 22963524.25 |   1.00 |          0.00 | 0.0095 |      24 B |
 TransientWithScopeValidation |  68.7545 ns | 1.3960 ns |  7.6460 ns | 14544498.22 |   1.58 |          0.19 | 0.0076 |      24 B |

Answer 3 · 2017-04-14T22:41:19.000Z

@danroth27 @DamianEdwards @Eilon do we want this on by default? Currently they can turn this on with a single line in program main.

If we want to turn this on by default, we'll need to do it across our tests firsts.

We were looking at this in DI triage with @davidfowl and @pakrym and we're not sure if this should be done.

Answer 4 · 2017-04-14T22:52:49.000Z

It would be really nice if this was on by default, but we would need to test the perf impact.

Answer 5 · 2017-04-14T22:56:13.000Z

Perhaps we should just update the templates to have it on by default for Development only?

Answer 6 · 2017-04-17T16:02:58.000Z

@DamianEdwards that sounds reasonable to me. And we would also enable it at least for a portion of the tests, right?

Answer 7 · 2017-04-21T09:05:45.000Z

That requires use to expose a callback here https://github.com/aspnet/Hosting/blob/51f77ea7f3b4a704691d0def9dd746fe0e32d5dc/src/Microsoft.AspNetCore.Hosting/WebHostBuilderExtensions.cs#L91 that exposes the HostingContext.