BuildServiceProvider should return IServiceProvider instead of ServiceProvider

Question

BuildServiceProvider should return IServiceProvider instead of ServiceProvider

cknaap opened this issue 7 years ago · 2 comments

Method Microsoft.Extensions.DependencyInjection.ServiceCollectionContainerBuilderExtensions.BuildServiceProvider returns a ServiceProvider instead of the associated interface IServiceProvider.

The latter allows for better mocking in unit tests.

Plus, the documentation on the method also says it returns IServiceProvider.

Answer 1 · 2017-11-27T15:53:29.000Z

No, it shouldn't. How can you mock an extension method? This method is about building a concrete implementation of an IServiceProvider.

Plus, the documentation on the method also says it returns IServiceProvider.

It was changed in 2.0 and needs to be updated /cc @Rick-Anderson

Answer 2 · 2018-01-01T07:23:47.000Z

This issue was moved to dotnet/aspnetcore#2329