Rails 5 Support

Question

Rails 5 Support

tansaku opened this issue 6 years ago · 4 comments

Working with Rails 5 we get the following issue:

Directly inheriting from ActiveRecord::Migration is not supported

Answer 1 · 2018-08-31T15:03:35.000Z

Is this a deprecation warning or an error? This would be good to fix however.

…

On Tue, Aug 28, 2018 at 12:59 PM Sam Joseph ***@***.***> wrote: Working with Rails 5 we get the following issue: Directly inheriting from ActiveRecord::Migration is not supported — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#348>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFxKdV_MDK1wBKA5WifnTJGg5ItTmIpks5uVXbwgaJpZM4WQBUt> .

Answer 2 · 2018-08-31T15:32:03.000Z

hi @phillbaker it was a blocking error I think

Answer 3 · 2018-09-29T16:12:52.000Z

Looks like https://github.com/RolifyCommunity/rolify/pull/463/files is a good approach.

Answer 4 · 2018-10-16T01:09:42.000Z

Fixed in b20d733