Events component needs scaling
Opened this issue ยท 6 comments
louicoder commented
The component displaying the Events home navigation route is not scaling as expected on devices with bigger width.
- You might want to use
display: flex
for the Top most View. Also Dimensions.get('width') can help to resolve this. - Tested this behavior on a 6" screen.
Note: when I get some free time, I will try to help and refactor. Otherwise great work on the color selection. You might also wanna think about having 2 modes i.e Light mode
and Dark Mode
cc: @Albystein
louicoder commented
Also notice that you did not pass a key property to the top most element in the loop, thus the warning. ๐
atemaguer commented
nice work. I will sit down tomorrow and work on this issues. to make them
responsive on all screens.
โฆOn Tue, 21 May 2019, 19:22 Musanje Louis Michael, ***@***.***> wrote:
The component displaying the Events home navigation route is not scaling
as expected on devices with bigger width.
- You might want to use display: flex for the Top most View. Also
Dimensions.get('width') can help to resolve this.
- Tested this behavior on a 6" screen.
Note: when I get some free time, I will try to help and refactor.
Otherwise great work on the color selection. You might also wanna think
about having 2 modes i.e Light mode and Dark Mode
cc: @Albystein <https://github.com/Albystein>
Screenshots:
[image: image]
<https://user-images.githubusercontent.com/32771081/58112941-2d644880-7bfd-11e9-9360-823af17f87a4.png>
[image: image]
<https://user-images.githubusercontent.com/32771081/58113184-a368af80-7bfd-11e9-8d9c-d79d880c0aa2.png>
โ
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AF6XZLAXE3MRSLHD2RVRJJDPWQOSZANCNFSM4HOMVYMA>
.
atemaguer commented
yeah that I know. something I had just forgotten about.
I committed before I had worked on it
โฆOn Tue, 21 May 2019, 19:25 Musanje Louis Michael, ***@***.***> wrote:
Also notice that you did not pass a key property to the top most element
in the loop, thus the warning. ๐
โ
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AF6XZLCFBON3HKHISNIU4ILPWQO7HANCNFSM4HOMVYMA>
.
louicoder commented
@Albystein Good work bro. Keep going. You might wanna review some stuff we working on. Will keep you posted.
atemaguer commented
send link
โฆOn Tue, 21 May 2019, 19:30 Musanje Louis Michael, ***@***.***> wrote:
@Albystein <https://github.com/Albystein> Good work bro. Keep going. You
might wanna review some stuff we working on. Will keep you posted.
โ
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AF6XZLEP3OQBHPNEIIWPOWLPWQPRPANCNFSM4HOMVYMA>
.
louicoder commented
Here's the link. You can follow the development process. Currently Develop branch is the only one up to date @Albystein