atom/notifications

Capturing errors always runs `apm ls --json --no-color` and renders atom unusable for an amount of time

despairblue opened this issue · 3 comments

Everytime an error dialog is shown:

screen shot 2015-11-28 at 13 54 04

apm ls --json --no-color is run producing this profile:

screen shot 2015-11-28 at 13 55 12

screen shot 2015-11-28 at 13 58 07

It renders atom unusable for about a minute or so (using 100% cpu for handling apm ls --json --no-color's output, which is only 10mb)

Also clicking the reporting button has no effect until atom finishes this process.

It could be one reason for atom/atom#3426

I tried to find the code that runs apm ls --json --no-color, but unsuccessful.

Versions

  • Atom: 1.3.0-beta6
  • Atom-Shell:
  • OS: Mac OS X 10.10.5
  • Misc
    • apm 1.1.1
    • npm 2.13.3
    • node 0.10.40
    • python 2.7.10
    • git 2.5.1

(moved from atom/atom#9856 (comment))

Thanks for the detailed report.

I tried to find the code that runs apm ls --json --no-color, but unsuccessful.

It's right here. We should be caching them or getting them from the package manager. Definitely not ideal.

here's a PR for pulling package names and versions from package manager.
#117

Fixed by #117.