attestate/ERC4973

Issues

• Is ERC4973 backwards compatible with ERC721

  #63 opened 2 years ago by umerarif01
  3

• Implement burn and issue auth

  #60 opened 2 years ago by TimDaub
  2

• Replace `function getHash()` with eip-5267

  #62 opened 2 years ago by TimDaub
  0

• Make most external interface functions overrideable like e.g. OZ's ERC721 implementation

  #61 opened 2 years ago by TimDaub
  0

• Question: payload to approve signatures from Gnosis Safe

  #50 opened 2 years ago by rahulrumalla
  4

• Agreement signature has changed to `bytes metadata` and so the sdk has to be updated too

  #56 opened 2 years ago by TimDaub
  2

• Failing tests: testGiveEOA() and testTakeEOA()

  #46 opened 2 years ago by ra-phael
  2

• An additional `bytes calldata data` to give and take could help extending the interface's functionality

  #59 opened 2 years ago by TimDaub
  0

• implement eip-5267 for structured eip-712 domain retrieval

  #49 opened 3 years ago by TimDaub
  2

• change `string uri` to `bytes metadata` in give and take function

  #51 opened 2 years ago by TimDaub
  0

• Is it a problem that `testTakeEOA` and `testGiveEOA` produce the same validation signature?

  #42 opened 3 years ago by TimDaub
  2

• consider making _mint private so that it is absolutely not used by implementers

  #48 opened 3 years ago by TimDaub
  0

• testTakeWithDifferentTokenURI

  #47 opened 3 years ago by ra-phael
  0

• Consider using vm.prank instead of account abstraction in Badges.t.sol

  #45 opened 3 years ago by grp06
  2

• Cannot import ERC4793.sol from NPM package

  #43 opened 3 years ago by markcutajar
  2

• Consider adding totalSupply

  #44 opened 3 years ago by rahulrumalla
  1

• Question: why is from address in TransferEvent hardcoded to address(0)?

  #39 opened 3 years ago by rahulrumalla
  6

• Inclusion of uri in Transfer event

  #40 opened 3 years ago by rahulrumalla
  4

• Decleration shadow for tokenURI

  #38 opened 3 years ago by markcutajar
  1

• Unused variable `inventory`

  #37 opened 3 years ago by rahulrumalla
  1

• Release as npm Package

  #1 opened 3 years ago by slavakurilyak
  1

• Remove manually increased tokenId with uint256 generated through type cashing Agreement hash

  #34 opened 3 years ago by TimDaub
  0

• IERC4973 function give and function take need natspec comments

  #35 opened 3 years ago by TimDaub
  0

• Now that function burn was renamed to function unequip we can't distinguish between someone disassociating themselves or "trashing" an item and someone unequipping it

  #36 opened 3 years ago by TimDaub
  0

• Validate re-introducing event Transfer(address,address,uint256) signature to improve backward-compatibility

  #4 opened 3 years ago by TimDaub
  1

• implement mint with permission

  #7 opened 3 years ago by TimDaub
  8

• Combine Permit and regular standard interface

  #33 opened 3 years ago by TimDaub
  0

• consider renaming `mintWithPermission` to `mintFrom`

  #26 opened 3 years ago by TimDaub
  3

• Introduce a .editorconfig that defines repositories tabwidth

  #9 opened 3 years ago by TimDaub
  0

• once https://github.com/ethereum/EIPs/pull/5193 is merged, create new tag for 3b906d5

  #31 opened 3 years ago by TimDaub
  0

• Provide means to internally call mintWithPermission

  #21 opened 3 years ago by rahulrumalla
  5

• Risk in _mint() not using Counters

  #27 opened 3 years ago by rahulrumalla
  1

• Fixing solc_version = '0.8.6 in foundry.toml makes compiler throw:

  #29 opened 3 years ago by TimDaub
  0

• Question: How to call mintFromPermission from front-end?

  #28 opened 3 years ago by rahulrumalla
  3

• The from in mintWithPermission must also allow a contract account (e.g. where the contract implements a permitter interface)

  #24 opened 3 years ago by TimDaub
  0

• consider foundry recommendation on how to test EIP-712

  #25 opened 3 years ago by TimDaub
  0

• mintWithPermission is infinitely callable but should only be callable once per type hash voucher

  #22 opened 3 years ago by TimDaub
  9

• public interface mintWithPermission must not have uint256 tokenId as it introduces synchronicity requirement for callers

  #19 opened 3 years ago by TimDaub
  5

• Separate IERC4973Permit as file and then inherit in ERC4973Permit

  #17 opened 3 years ago by TimDaub
  1

• author field should include url to file

  #16 opened 3 years ago by TimDaub
  0

• consider making ERC4973Permit typehash `immutable`

  #14 opened 3 years ago by TimDaub
  1

• remove inconsistently applied underscore naming convention of internal function

  #13 opened 3 years ago by TimDaub
  0

• remove inconsistent underscore input parameter convention

  #12 opened 3 years ago by TimDaub
  0

• Implement balanceOf

  #11 opened 3 years ago by TimDaub
  0

• Add safeMint function

  #3 opened 3 years ago by TimDaub
  0

• set up a linter that checks if files all use two spaces

  #10 opened 3 years ago by TimDaub
  0

• implement optional mint with permission

  #6 opened 3 years ago by TimDaub
  1

• according to EIP-4973, function burn should now be exposed

  #5 opened 3 years ago by TimDaub
  0