attestate/libharberger

Issues

• Implement https://eips.ethereum.org/EIPS/eip-4907

  #37 opened 2 years ago by TimDaub
  0

• Allowing to set tax rate by beneficiary allows to artificially increase rate without potentially being noticed

  #36 opened 3 years ago by TimDaub
  0

• before changing taxrate with setTaxRate, it should be settled with collateral

  #35 opened 3 years ago by TimDaub
  0

• for testFail tests, match message with expectrevert

  #34 opened 3 years ago by TimDaub
  0

• Run a gas benchmark on all external/public functions

  #33 opened 3 years ago by TimDaub
  0

• Make sure an external application can replicate all state through events

  #32 opened 3 years ago by TimDaub
  0

• Adjust "Usage" section in readme.md with example of using PluralProperty class

  #23 opened 3 years ago by TimDaub
  0

• Add Topup and withdraw events to interface

  #24 opened 3 years ago by TimDaub
  0

• fix failing github actions tests

  #22 opened 3 years ago by TimDaub
  0

• add setTaxRate(uint256 tokenId) function

  #19 opened 3 years ago by TimDaub
  0

• introduce tax struct

  #31 opened 3 years ago by TimDaub
  0

• topologically order functions by visibility

  #30 opened 3 years ago by TimDaub
  0

• Merge Harberger.sol with PluralProperty.sol

  #26 opened 3 years ago by TimDaub
  0

• Implement `baseURI` as it's implemented in OZ's ERC721URIStorage (ideally also optional)

  #10 opened 3 years ago by TimDaub
  0

• what methods need to be publicly available to build a UI?

  #5 opened 3 years ago by TimDaub
  0

• Implement withdraw function to lower price

  #25 opened 3 years ago by TimDaub
  0

• sending old value to current person topping up makes no sense; just settle taxes in _settleAssessment

  #29 opened 3 years ago by TimDaub
  0

• consider moving _settleAssessment's transfers to the very end of buy and topup (to avoid risk of reentrancy)

  #28 opened 3 years ago by TimDaub
  0

• find a way to consistently order function modifiers (e.g. such that payable is always last etc.)

  #27 opened 3 years ago by TimDaub
  0

• test buying property after a significant time passed

  #20 opened 3 years ago by TimDaub
  0

• end to end test for buying and selling

  #21 opened 3 years ago by TimDaub
  0

• implement method for self-assessing property value using `increment` and `decrement` functions

  #8 opened 3 years ago by TimDaub
  0

• define tax beneficiary along with taxrate

  #12 opened 3 years ago by TimDaub
  0

• Make sure implementation works as `abstract contract` similar to how OZ's ERC721 works

  #9 opened 3 years ago by TimDaub
  0

• add getAssessment(tokenId) function

  #14 opened 3 years ago by TimDaub
  0

• test getting price of property after a significant period

  #15 opened 3 years ago by TimDaub
  0

• Compute IPluralProperty interface hex hash

  #7 opened 3 years ago by TimDaub
  0

• Allow pricing property with ERC20 tokens; specifically to allow pricing in USD with stable coins

  #18 opened 3 years ago by TimDaub
  0

• Deprecate rugpullindex/pluralproperty and merge readme.md text in here

  #11 opened 3 years ago by TimDaub
  0

• remove pluralproperty git submodule

  #16 opened 3 years ago by TimDaub
  0

• taxRate in mint as input is vulnerable and shouldn't be publicly controllable

  #17 opened 3 years ago by TimDaub
  0

• seek consistency with naming function inputs

  #13 opened 3 years ago by TimDaub
  0

• fix string formatting in PluralProperty.sol

  #6 opened 3 years ago by TimDaub
  0

• Downward price discovery isn't properly factored into the model

  #2 opened 3 years ago by TimDaub
  1

• using transfer before state changes can lead to reentrancy attack

  #4 opened 3 years ago by TimDaub
  1

• Harberger Tax NFT -- RadicalxChange Working Group

  #1 opened 3 years ago by erichfi
  1

• test if price calculation is precise up to 18 decimals; rename percentage to "Parts per"

  #3 opened 3 years ago by TimDaub
  0