aws/aws-encryption-sdk-c

Unpin MacOS CI builds from CMake 3.19.3

Opened this issue · 1 comments

The hosted GitHub Actions runners for macOS recently upgraded the default CMake version to v3.19.1, leading to build failures: #650

We implemented a workaround that involves downgrading CMake to the prior version, v3.18.5: #655

We should root cause the build failure, and determine (a) what changes to make to our build configuration so that we can use newer CMake versions, or (b) whether we need to just wait for a CMake version with the regression patched. Afterwards we should revert the workaround.

From #692

CMake 3.19.1 seems to have a problem with aws-checksums configuration. This appears to be a bug fixed in CMake because the build works fine with 3.19.3 and the older versions of CMake that this change upgrades.

Unfortunately 3.19.1 is the version in GitHub Actions' MacOS 10.15 image right now, see https://github.com/actions/virtual-environments/blob/main/images/macos/macos-10.15-Readme.md

Attempting to use Homebrew, 3.19.3 is generally exposed but is not exposed to the GHA environment.

In any event, manually pulling 3.19.3 from CMake's repository the way we were pulling 3.18.5 does the trick.

I am leaving #658 open though because eventually it would be nice to remove this version pinning entirely.