System.UriFormatException on MessageConfig.FileBaseDirectory with relative path.

[rtieland]

When a relative path is used for the property FileBaseDirectory an exception System.UriFormatException: 'Invalid URI: The format of the URI could not be determined.' is thrown.

For example:

FileBaseDirectory = ".\Templates\Attachments"; //Throws exception
FileBaseDirectory = Path.Combine(Directory.GetCurrentDirectory(), "Templates\Attachments"); //Doesn't thow exception.

[axunonb]

This is by design:

1. The FileBaseDirectory must be an absolute path. The default currently is Path.GetTempPath().
2. The file paths (e.g. attachments) are relative to the FileBaseDirectory.

I updated the xmldoc of the property accordingly.
Does this make sense to you?

[axunonb]

Do you have a proposal to improve or should we close the issue?

[rtieland]

The only improvement I can think of is check the path when it is set. Now there is only an exception when htmlbody is set and processed.

…

________________________________ Van: Norbert Bietsch <notifications@github.com> verzonden: woensdag 5 september 2018 23:58 Aan: axuno/MailMergeLib Cc: rtieland; Author Onderwerp: Re: [axuno/MailMergeLib] System.UriFormatException on MessageConfig.FileBaseDirectory with relative path. (#18) Do you have a proposal to improve or should we close the issue? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Faxuno%2FMailMergeLib%2Fissues%2F18%23issuecomment-418895039&data=02%7C01%7C%7Cbea1b4fb7a44498013ea08d6137aa8e4%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636717814865163651&sdata=Dih0dyZXiYxKGUTPlxV8m5Jx4oMX2CO6RjDE7pL3GyE%3D&reserved=0>, or mute the thread<https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FASquMQWPBgbhP94dsEf2HEyrA-tWVO9-ks5uYEjtgaJpZM4WHNSE&data=02%7C01%7C%7Cbea1b4fb7a44498013ea08d6137aa8e4%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636717814865163651&sdata=mOjNOJtmNn8G2Qjz89s%2BcQYM07WBUaSjX7%2F5keZh3GI%3D&reserved=0>.

[axunonb]

Commit 88ea355 addresses your proposal: MessageConfig.FileBaseDir will now be checked for an absolute path. This is the earliest checkpoint. Issue resolved?

[rtieland]

Yes that's perfect.

…

________________________________ Van: Norbert Bietsch <notifications@github.com> verzonden: donderdag 6 september 2018 21:12 Aan: axuno/MailMergeLib Cc: rtieland; Author Onderwerp: Re: [axuno/MailMergeLib] System.UriFormatException on MessageConfig.FileBaseDirectory with relative path. (#18) Commit 88ea355<https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Faxuno%2FMailMergeLib%2Fcommit%2F88ea35507b0a78d69c3aa1e3626e4cc7f581054f&data=02%7C01%7C%7C2faa451fe55a403493f508d6142cacb6%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636718579433184922&sdata=JRRINtnFQQN4eVXIGy%2FJwy73JlWFU0Lg9Mgb17QeLNU%3D&reserved=0> addresses your proposal: MessageConfig.FileBaseDir will now be checked for an absolute path. This is the earliest checkpoint. Issue resolved? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Faxuno%2FMailMergeLib%2Fissues%2F18%23issuecomment-419208562&data=02%7C01%7C%7C2faa451fe55a403493f508d6142cacb6%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636718579433184922&sdata=iajuVWydMy%2FqXyGq4rH6OY9z%2F%2F%2FQ76D7ikbVhENn%2Fog%3D&reserved=0>, or mute the thread<https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FASquMW7LPpUxKOGENiGbPALOrh3ed8f8ks5uYXOWgaJpZM4WHNSE&data=02%7C01%7C%7C2faa451fe55a403493f508d6142cacb6%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636718579433184922&sdata=jjwL2zZZwTmKFKTW%2B8l2slgyTCWXliLob4kLFc2o7yM%3D&reserved=0>.

[axunonb]

It turned out in v5.6.0, that checking MessageConfig.FileBaseDir for a full path already when setting the property causes problems in a web environment, where the final full path is set after the MessageConfig is read from a configuration file.
In v5.6.1 the full path for MessageConfig.FileBaseDir will be checked while the MailMergeMessage's Send... or GetMimeMessage() methods are called.

[axunonb]

Closed with release v5.6.1.0