azavea/green-equity-demo

Typescript lint warnings in console

Opened this issue · 1 comments

Overview

There are a lot of compile warnings in the logs and console of the demo right now.

Expected Behavior

We want to always have our React apps running with no errors or warnings, e.g. "Compiled successfully" every commit

Actual Behavior

There are many warnings. Most are "Unexpected any" and "Forbidden non-null assertion" and luckily the compiler tells us what files and line numbers to fix.

Steps to Reproduce

  • Go to the develop branch and run ./scripts/server
  • Once the app is running there will be a "Compiled with warnings." message and then all of the respective warnings

Demo

image

Thanks, I forgot to open a card for this. We discussed it here:
#86 (comment)

Some of these are tolerable, so we could add a tslint ignore, but they need to be considered individually.