babarot/enhancd

Stuck

NikoGrano opened this issue · 17 comments

What did you expect to happen?
Change directory

What actually happened?
Will stay stuck

Output

Nothing

Additional context
image
It will stay there stuck forever.

Confirming that I'm having this issue on a fresh install of fish as well. No other packages installed and nothing else configured.

Can't reproduce it, how did you install enhancd ?

When I was using fish (have since stopped) I believe I was on Ubuntu using a ppa propbably (going off of what I'm seeing on their github). I attempted to install enhancd via the fish integration that's detailed here because I was using OMF. As I had explained, my OMF was 100% stock, ehancd was the first thing I'd tried to add.

Which was the fish version you were using ?

I can attempt to confirm that in a bit. I need to double check my laptop and see if it's still in the same config. If it is I'll let you know what fish version I was on and I'll attempt a min-config quickly as well.

I suggest you to try fish 3.0.2 or 3.0.1, the bug you described may has been fixed if you were using an older version

I will recheck this today.

Sorry I haven't gotten a chance to update this yet. I don't frequently use the computer where I was having the issue.

Forgot and had few days off...I will try remember to check this out in next 8-12hours..

@gazorby got a chance to look just now. It looks as if I have not installed via PPA but rather through apt and I'm running fish version 2.7.1. I've changed over to the fish mantainer's ppa and attempted a reinstall via omf install https://github.com/b4b4r07/enhancd as listed on the readme and I'm currently running into this output.

Updating https://github.com/oh-my-fish/packages-main master... Done!
Installing package enhancd
~/.local/share/omf/pkg/omf/functions/bundle/omf.bundle.add.fish (line 11): Expected a string, but instead found a '&'
    if not grep $record $bundle > /dev/null ^&1
                                             ^
from sourcing file ~/.local/share/omf/pkg/omf/functions/bundle/omf.bundle.add.fish
	called on line 1 of file ~/.local/share/omf/pkg/omf/functions/packages/omf.packages.install.fish
in command substitution
	called on line 55 of file ~/.local/share/omf/pkg/omf/functions/packages/omf.packages.install.fish
in function 'omf.packages.install' with arguments 'https://github.com/b4b4r07/enhancd'
	called on line 13 of file ~/.local/share/omf/pkg/omf/functions/cli/omf.cli.install.fish
in function 'omf.cli.install' with arguments 'https://github.com/b4b4r07/enhancd'
	called on line 2 of file -
in function '__omf_last_command' with arguments 'https://github.com/b4b4r07/enhancd'
	called on line 50 of file ~/.local/share/omf/pkg/omf/functions/omf.fish
in function 'omf' with arguments 'install https://github.com/b4b4r07/enhancd'
source: Error while reading file “/home/sofubi/.local/share/omf/pkg/omf/functions/bundle/omf.bundle.add.fish”
omf.bundle.add: command not found
~/.local/share/omf/pkg/omf/functions/packages/omf.packages.install.fish (line 55):
    omf.bundle.add package $name_or_url
    ^
in function 'omf.packages.install' with arguments 'https://github.com/b4b4r07/enhancd'
	called on line 13 of file ~/.local/share/omf/pkg/omf/functions/cli/omf.cli.install.fish
in function 'omf.cli.install' with arguments 'https://github.com/b4b4r07/enhancd'
	called on line 2 of file -
in function '__omf_last_command' with arguments 'https://github.com/b4b4r07/enhancd'
	called on line 50 of file ~/.local/share/omf/pkg/omf/functions/omf.fish
in function 'omf' with arguments 'install https://github.com/b4b4r07/enhancd'
✔ enhancd successfully installed.

After running exec fish I'm still running into the issue where running cd just hangs.

Facing the same issue.

OS:
ProductName: Mac OS X
ProductVersion: 10.15.3
BuildVersion: 19D76

fish, version 3.1.0

Oh My Fish version 6

Installation - omf install https://github.com/b4b4r07/enhancd

Can't CD at all, rendering the whole system dead in the water

Windows 10 Pro Insider Preview 19603 fish version 3.1.0 fisher version 3.2.10 << install method

Installation - omf install b4b4r07/enhancd

edit: Restored cd functionality via rm ~/.config/fish/functions/_enhancd*

Having same issue.

OSX Catalina 10.15.4

installed as fisher add b4b4r07/enhancd

Screenshot 2020-05-04 at 23 34 58

Having this as well, using omf on Arch. I believe it was working okay at first, but I had removed enhancd to troubleshoot something. After reinstalling, using cd in any context causes it to hang

Try to use my fork before my PRs get merged, i made some changes that may fix this issue

Same happened to me after installing through omf. Terminal would fail to start (because I had a cd in my fish config file). Seemed like an infinite loop, because when I would functions -e cd, things would return to normal until I restarted my shell.

For those stuck on this, I eventually did

omf remove enhancd`

I'll give it a try again when this is fixed.

Fixed in 7085570. Please update to the latest enhancd and let us know if you still have any issues. 👋

@Quantumplation @NikoGrano @66Antigravity @Kenney-G @sofubi