Stop shipping source map for transpiled files
Closed this issue · 7 comments
This library ships two maps: one for transpiled files, and one for minified files. The transpiled map only makes sense if:
- the libs are distributed with the source files
- the consumer sets up their browser to serve the source files
The first of those points is generally true for users of the babel boilerplate since we don't exclude the src directory from package.json by default (maybe we should?). But the 2nd requirement is pretty steep, and probably isn't true for most consumers.
For this reason, I think we should stop shipping the transpiled map and only ship the minified one.
//cc @megawac @paulfalgout
You aren't required to have the source files available in order to view
source map files AFAIK. However I'm = to this proposal
On Fri, Jun 3, 2016 at 1:52 PM, James, please notifications@github.com
wrote:
This library ships two maps: one for transpiled files, and one for
minified files. The transpiled map only makes sense if:
- the libs are distributed with the source files
- the consumer sets up their browser to serve the source files
The first of those points is generally true for users of the babel
boilerplate since we don't exclude the src directory from package.json by
default (maybe we should?). But the 2nd requirement is pretty steep, and
probably isn't true for most consumers.For this reason, I think we should stop shipping the transpiled map and
only ship the minified one.//cc @megawac https://github.com/megawac @paulfalgout
https://github.com/paulfalgout—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#359, or mute
the thread
https://github.com/notifications/unsubscribe/ADUIEGFVPBHwApIarH_6u_pDoEGu-kcRks5qIGnZgaJpZM4Itwhs
.
I'll have to double-check to verify, but my understanding is that you do, since it has the names of the files and the path to access them within the map.
However I'm = to this proposal
Does that mean you don't have a strong feeling either way? :P
I'll have to double-check to verify, but my understanding is that you do, since it has the names of the files and the path to access them within the map.
Nope, the entire source contents are stored and references in source maps (thats why map files are so damn big)
Does that mean you don't have a strong feeling either way? :P
Yep
Nope, the entire source contents are stored and references in source maps (thats why map files are so damn big)
Interesting. If this is the case, then I won't make this change.
The gulp-sourcemap docs confirm that the content ships w. the map ✌️
I am getting this error in Chrome console with a package I made with this boilerplate: Failed to parse SourceMap.
But the map is under the /dist folder.