Update from bazel master?
keith opened this issue · 9 comments
This CI failure https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1664#d7f70432-54aa-4859-a2e6-a8bb365e99b1 is caused by having an out of sync toolchain with bazel's master toolchain.
What is the process for updating the rules_cc toolchain, especially given the changes are incompatible with previous versions of bazel?
/cc @oquenchil
The one in bazel is the source of truth. The one in this repo should be synced with the one in bazel, even if the changes are incompatible.
Who is responsible for the sync?
So I don't see what's out of sync. The culprit PR is changing the files tools/objc/libtool.sh and tools/osx/crosstool/BUILD.tpl which do not exist and are not copied in rules_cc.
Is it possible that bazelbuild/bazel#12046 is introducing an incompatible change and it was caught by that target in rules_cc?
I'm not familiar with osx. Please verify that bazelbuild/bazel#12046 is not an incompatible change. If we are getting an error that was silently ignored before but the build worked, I think that qualifies as an incompatible change. If it's not, michaeleisel@ could you be so kind to send a patch to rules_cc so that //examples/my_c_archive:all keeps building?
Thank you.
/cc @michaeleisel
@oquenchil what do you mean by incompatible? if you mean that it breaks for consumers of bazel besides rules_cc, the answer is no, there are no known issues. rules_cc is just a bit special because of its bootstrapping (@keith can elaborate more). i'd be happy to make a pr that fixes this in rules_cc. is it settled that we won't need to revert in the bazel repo?
(i'm asking because keith and i would like to see this change in the 3.6 rc)
Ah good to hear. Yes, if you can send the PR that fixes rules_cc that would be great, I couldn't figure out what needed to change there.