bbc/react-transcript-editor

Breaking change: `MediaPlayer` should be renamed `MediaControls`? `TransportControls`?

pietrop opened this issue · 2 comments

A possible breaking change suggestion, MediaPlayer (see in storybook) should be renamed MediaControls?

Since over time it has become decoupled from the actual HTML5 video player element, wrapped in VideoPlayer component, then perhaps the name should be a bit more representative?

Raising it as an issue, as it might be a breaking change for backward compatibility.

Why not use the classic name of those things: TransportControls as seen everywhere else:

Ah, interesting, had not seen this before, yeah, that would be a good name in line with existing conventions 👍