bdrister/AquaticPrime

inconsistent value sorting before hashing

Closed this issue · 2 comments

ppatpat commented

I have found sorting inconsistencies depending on the language used for validating a license i.e. C/C++ STL, PHP etc.
I think that could be easily attributed to the different supporting functions available on each of those languages.
I wonder why sorting before hashing is really necessary?? It does not make the system more secure and it makes things very complicated from a portability point of view.
why the hash is not calculated from the first key/value pair in the license til the last one and we avoid all this portability hassle??

Best,
Patrick

bdrister commented

Closing as a duplicate of #6.

ppatpat commented

It is related but not a "duplicate"; i.e. can you answer the questions:

I wonder why sorting before hashing is really necessary??
Why the hash is not calculated from the first key/value pair in the license til the last one and we avoid all this portability hassle??