Remove the horizontal scroll of the page

Question

Remove the horizontal scroll of the page

Closed this issue 3 years ago · 11 comments

Answer 1 · 2021-10-11T17:48:07.000Z

hey @beatrizsmerino, can i work on this !?

Answer 2 · 2021-10-11T17:51:34.000Z

Of course ! :)
Please just keep the same indentation and nomenclature that is in the whole project (lint, prettir, BEM...)

Answer 3 · 2021-10-11T18:27:30.000Z

@od-c0d3r I think that the problem has not been solved, I still see the horizontal scroll.
I think it is because I used in users-list__item a margin: 1rem and removed the extra side margins giving a negative margin to users-list__wrapper.
I would like to keep the margins of 'users-list__item'.

Answer 4 · 2021-10-11T18:34:20.000Z

Thank you for pointing it out,
i'm trying to get the app up locally but it fails when I npm run server or build with error

ERROR  Failed to compile with 1 error                                                                                                                                                        8:32:36 PM
Syntax Error: TypeError: eslint.CLIEngine is not a constructor

Answer 5 · 2021-10-11T18:37:03.000Z

ok I will check this error

Answer 6 · 2021-10-11T18:51:15.000Z

Thank you for pointing it out, i'm trying to get the app up locally but it fails when I npm run server or build with error
ERROR  Failed to compile with 1 error                                                                                                                                                        8:32:36 PM
Syntax Error: TypeError: eslint.CLIEngine is not a constructor

It is strange, it lets me launch it without errors.

Have you done this?

npm install
npm run serve
Can you see on which line the error is displayed and send me a screenshot?

Answer 7 · 2021-10-11T18:59:18.000Z

i did install before build or serve yes

Answer 8 · 2021-10-11T19:35:03.000Z

what do u think about this #126 ?

Answer 9 · 2021-10-11T19:58:58.000Z

what do u think about this #126 ?

sorry, I'm checking the dependencies and adding the eslint and prettier configuration.

Answer 10 · 2021-10-11T22:53:02.000Z

what do u think about this #126 ?

OK I think that the error it is fixed.
Please can you delete and clone the project again?
I have removed the last update of eslint 8.0.0 dependency, it was not working properly.
And I added the eslint and prettier configuration, you can fix the errors by running the command npm run lint.

Answer 11 · 2021-10-11T23:02:27.000Z

I think if you delete margin: 0 -1rem 4rem and add this margin-bottom: 4rem, it fixes the horizontal scrolling, but keeps the side margins.