ttl type inconsistent
venkatramanm opened this issue · 5 comments
Name: Protocol Specifications
Title: "ttl type inconsistent"
Labels: C4GT Community
Description
ttl in provider object is of type integer where every where else it is of type Duration ( ISO8601 format) Need to fix for consistency.
Goals
- Check and maintain consistency
Expected Outcome
- Check and maintain consistency
Implementation Details
- Update Provider TTL to Duration
Project
Beckn
Organization Name:
Beckn Open Collective
Domain
Others
Tech Skills Needed:
Open API 3.0
Github actions
Mentor(s)
Ravi Prakash
Complexity
Low
Category
Bug
Sub Category
Reproducible
@ravi-prakash-v ttl is used at 6 places in the Core Specs ( Transaction.yaml). should we change all as '#/components/schemas/Duration'
- Catalogue
ttl:
description: Duration in seconds after which this catalog will expire
type: string
- Category
ttl:
description: Time to live for an instance of this schema
- Context
ttl:
description: The duration in ISO8601 format after timestamp for which this message holds valid
type: string
- Item
ttl:
description: Time to live in seconds for an instance of this schema
type: string
- Provider
ttl:
description: 'The time-to-live in seconds, for this object. This can be overriden at deeper levels. A value of -1 indicates that this object is not cacheable.'
type: integer
minimum: -1
- Quotation
ttl:
$ref: '#/components/schemas/Duration'
Hi!
Mandatory Details - The following details essential to submit tickets to C4GT Community Program are missing. Please add them!
- Product Name - Please add a heading called Product Name and mention the name of the product below it.
Without these details, the ticket cannot be listed on the C4GT Community Listing.
Please update the ticket
Let's change all ttl
datatypes to Duration
schema.
Hi @ravi-prakash-v , the PR has been raised for the above issue. Please find it here - #386
Hi @venkatramanm ,
I'm pleased to inform you that the issue #343 has been fixed and merged. Thanks for your contribution! Feel free to reopen or create a new issue for further discussions.
Best,
@emmayank