benetech/MathShare

Bug: All users repeatedly asked to Review Account Info

Opened this issue · 2 comments

Related to #1523

Expected behavior (From the original scope):

Given that I'm a student signing in for the first time after the update, I should be redirected to review my account information.

Given that I'm a teacher or other account signing in for the first time after the update, I should NOT be redirected to review my account information, and should be able to proceed through the application as normal.

Current behavior:
ALL accounts (including accounts recorded as "Teacher" or "Other" accounts) are repeatedly being asked to review the account information.

This should not be occurring for Teacher or Other accounts, and should only be occurring the singular time (first sign-in post-update) for student accounts.

More info on replication:

  • I used my alexc@benespace.org google account, which is an older account
  • This was previously registered as a Teacher account
  • Log-in / log out is handled through an SSO on top of the usual google login (Centrify)

@abaranowska1 We need some help tracking down how to reliably reproduce this. I think there are a few combinations of things to try

  • Brand new accounts vs. Existing accounts
  • Filling out the info vs. leaving some info blank
  • Teacher vs. student

There's also been some reports of this being retriggered both from log-out/ re-login as well as remaining logged in and leaving the page and coming back

@johnhbenetech @alexrcabral
It is hard to reproduce it for me. I tried a few combinations.

  1. I logged in as old "teacher" account which i didn't use for months and I didn't have "Review Account Info" modal
  2. I logged in as empty "other" account and I set that I'm a student and I filled out all info - I didn't have "Review Account Info" modal
  3. I logged in as old "student" account and I saw "Review Account Info" modal