benetech/MathShare

Desktop Sidebar: Remove "Home" 

Opened this issue · 5 comments

alexrcabral commented

Proposed Mockup

Mockup of v2 Mathshare sidebar on desktop. This shows a profile portrait with the initial A. Underneath is the name Alex C in bold, followed by Teacher, and Signout. The main portion of the sidebar is shown beneath. These options read My Solution Sets, My Created Sets, Example Sets, About Mathshare, Help Center, and Accessibility. My Created Sets is currently active, which is represented by bold, darker font.

In the list of linked options on the sidebar, "Home" should be removed since it doesn't provide anywhere to link separate from "My Sets". 

Reference

Style Guide: https://invis.io/CQYLLW8J49U
Fonts: https://www.dropbox.com/sh/c12m6ufweyds20d/AAAdXNPOt8e52DkSAr9pd-a-a/Fonts?dl=0

Acceptance criteria: 

Given that I'm a user who is on a screen wide enough to view the sidebar, I should no longer encounter the Home link as the first link. (My Solution Sets and My Created Sets should be first.) 

abaranowska1 commented

@rupeshparab Probably the changes are not deployed on QA instance
image

rupeshparab commented

@abaranowska1
Its PR has been merged: https://github.com/benetech/MathShare/pull/1656/files
I looked into the build notifications to check if build has failed, but it seems no build got trigerred today

@johnhbenetech
Can you check if there is any issue due to which build is not being triggered?

rupeshparab commented

@abaranowska1
Changes have been deployed now

abaranowska1 commented

@rupeshparab @alexrcabral
Home link is not displayed as the first link - it was removed but My Solution Sets and My Created Sets should be first - now I see only My Sets
image

rupeshparab commented

@abaranowska1
there is a different task for change from My Sets to My Solution Sets and My Created Sets, I think we can track this change on it:
#1636

  • 👍1