benfreke/oc-menumanager-plugin

Extra URL parameters issue

Closed this issue · 5 comments

I'm seeing a problem with the "Extra URL parameters".
I am using the { 'slug' : 'slugvalue' } format for the "Extra URL parameters" field but the URL always gets set to:

'url/default'

instead of

'url/slugvalue'

Any help would be appreciated. Thanks!

Hi Mate

I'm at work today but I'll have a look at this when I get home.

On 17 July 2014 09:00, blitworxUser notifications@github.com wrote:

I'm seeing a problem with the "Extra URL parameters".
I am using the { 'slug' : 'slugvalue' } format for the "Extra URL
parameters" field but the URL always gets set to:

'url/default'

instead of

'url/slugvalue'

Any help would be appreciated. Thanks!


Reply to this email directly or view it on GitHub
#24.

Thanks!
Cheers

-chad

On Jul 16, 2014, at 4:03 PM, benfreke notifications@github.com wrote:

Hi Mate

I'm at work today but I'll have a look at this when I get home.

On 17 July 2014 09:00, blitworxUser notifications@github.com wrote:

I'm seeing a problem with the "Extra URL parameters".
I am using the { 'slug' : 'slugvalue' } format for the "Extra URL
parameters" field but the URL always gets set to:

'url/default'

instead of

'url/slugvalue'

Any help would be appreciated. Thanks!


Reply to this email directly or view it on GitHub
#24.


Reply to this email directly or view it on GitHub.

I figured it out.
I mistakenly had single quotes on my json object in the field. proper JSON must have double quotes.
Sorry about that
Great plugin!

Thanks
chad

On Jul 16, 2014, at 4:03 PM, benfreke notifications@github.com wrote:

Hi Mate

I'm at work today but I'll have a look at this when I get home.

On 17 July 2014 09:00, blitworxUser notifications@github.com wrote:

I'm seeing a problem with the "Extra URL parameters".
I am using the { 'slug' : 'slugvalue' } format for the "Extra URL
parameters" field but the URL always gets set to:

'url/default'

instead of

'url/slugvalue'

Any help would be appreciated. Thanks!


Reply to this email directly or view it on GitHub
#24.


Reply to this email directly or view it on GitHub.

That old chestnut :) I keep having the same error myself. Luckily my IDE
(PhpStorm) tells me about it. I tried to write a custom validator to warn
about this issue, but haven't yet managed to figure out how to put that in.

Glad the plugin is helping you :)

On 17 July 2014 16:16, blitworxUser notifications@github.com wrote:

I figured it out.
I mistakenly had single quotes on my json object in the field. proper JSON
must have double quotes.
Sorry about that
Great plugin!

Thanks
chad

On Jul 16, 2014, at 4:03 PM, benfreke notifications@github.com wrote:

Hi Mate

I'm at work today but I'll have a look at this when I get home.

On 17 July 2014 09:00, blitworxUser notifications@github.com wrote:

I'm seeing a problem with the "Extra URL parameters".
I am using the { 'slug' : 'slugvalue' } format for the "Extra URL
parameters" field but the URL always gets set to:

'url/default'

instead of

'url/slugvalue'

Any help would be appreciated. Thanks!


Reply to this email directly or view it on GitHub
#24.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#24 (comment)
.

There's been a recent PR that has added JSON validation, so this bug is fixed