bfenetworks/bfe

staticcheck action not in ci job

kwanhur opened this issue · 2 comments

kwanhur commented

staticcheck had been used in bfe, but it doesn't exist in ci job steps.

Add step staticcheck on pull request and push develop, helps to improve quality of codes.

marketplace here, but it's under MIT license.
Before using it, any license conflicts and CNCF policy limitations should take a care.

  • bfe under Apache License 2.0 and CNCF sandbox project
kwanhur commented

Another way, just add one step run with staticcheck binary. I think it hasn't any conflicts.

kwanhur commented

Advice adding staticcheck into pre-commit.