bloodyowl/rescript-js

Int.fromStringWithRadix (parseInt) missing

Closed this issue · 3 comments

Minnozz commented

The current binding has a fixed argument for the radix:

rescript-js/src/Js__Int.res

Line 19 in 802ef39

@val external fromString: (string, ~radix: @as(json`10`) _) => float = "parseInt"

bloodyowl commented

You have Float.parseIntWithRadix for that. The rationale behind putting it there is that it might return NaN which belongs to floats.

Minnozz commented

I see Int.fromString returns an option<int>; would that be an option for Int.fromStringWithRadix?

bloodyowl commented

I guess having a slight runtime on this wouldn't hurt given how often people can use it. Would you be able to send a PR?