Symfony deprecation trigger

Question

Symfony deprecation trigger

Nek- opened this issue 2 years ago · 6 comments

Hello,

I was wondering if you have a solution to avoid having all of this in the terminal:

2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::enterNode()" might add "int|Node|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\UseStatementPass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::leaveNode()" might add "int|Node|array|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\UseStatementPass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::beforeTraverse()" might add "?array" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\NamespacePass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::enterNode()" might add "int|Node|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\AbstractClassPass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::leaveNode()" might add "int|Node|array|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\AbstractClassPass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::enterNode()" might add "int|Node|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\AssignThisVariablePass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::beforeTraverse()" might add "?array" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\CalledClassPass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::enterNode()" might add "int|Node|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\CalledClassPass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::leaveNode()" might add "int|Node|array|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\CalledClassPass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::enterNode()" might add "int|Node|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\CallTimePassByReferencePass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::beforeTraverse()" might add "?array" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\FinalClassPass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::enterNode()" might add "int|Node|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\FinalClassPass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::beforeTraverse()" might add "?array" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\FunctionContextPass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::enterNode()" might add "int|Node|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\FunctionContextPass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::leaveNode()" might add "int|Node|array|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\FunctionContextPass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::enterNode()" might add "int|Node|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\FunctionReturnInWriteContextPass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::enterNode()" might add "int|Node|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\InstanceOfPass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::enterNode()" might add "int|Node|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\IssetPass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::beforeTraverse()" might add "?array" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\LabelContextPass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::enterNode()" might add "int|Node|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\LabelContextPass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::leaveNode()" might add "int|Node|array|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\LabelContextPass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::afterTraverse()" might add "?array" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\LabelContextPass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::enterNode()" might add "int|Node|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\LeavePsyshAlonePass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::enterNode()" might add "int|Node|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\ListPass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::beforeTraverse()" might add "?array" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\LoopContextPass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::enterNode()" might add "int|Node|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\LoopContextPass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::leaveNode()" might add "int|Node|array|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\LoopContextPass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::enterNode()" might add "int|Node|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\PassableByReferencePass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::enterNode()" might add "int|Node|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\ReturnTypePass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::leaveNode()" might add "int|Node|array|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\ReturnTypePass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::beforeTraverse()" might add "?array" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\EmptyArrayDimFetchPass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::enterNode()" might add "int|Node|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\EmptyArrayDimFetchPass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::beforeTraverse()" might add "?array" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\ValidConstructorPass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::enterNode()" might add "int|Node|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\ValidConstructorPass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::leaveNode()" might add "int|Node|array|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\ExitPass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::enterNode()" might add "int|Node|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\RequirePass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::beforeTraverse()" might add "?array" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\StrictTypesPass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::beforeTraverse()" might add "?array" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\NamespaceAwarePass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::enterNode()" might add "int|Node|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\NamespaceAwarePass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::enterNode()" might add "int|Node|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\ValidClassNamePass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::leaveNode()" might add "int|Node|array|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\ValidClassNamePass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::enterNode()" might add "int|Node|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\ValidFunctionNamePass" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-10-24T22:05:16+00:00 [info] User Deprecated: Method "PhpParser\NodeVisitor::leaveNode()" might add "int|Node|array|null" as a native return type declaration in the future. Do the same in implementation "Psy\CodeCleaner\ValidFunctionNamePass" now to avoid errors or add an explicit @return annotation to suppress this message.

Patching psysh to have proper return types is impossible since it supports PHP 7.0...

Answer 1 · 2022-10-25T01:10:14.000Z

Looks like we can solve it with @return declarations where the proper types are incompatible.

Answer 2 · 2022-10-25T07:23:27.000Z

Do you want me to make a PR for it ? :)

Answer 3 · 2022-10-25T11:13:16.000Z

That would be awesome!

Answer 4 · 2022-11-05T13:41:55.000Z

@Nek- how are you getting these deprecation notices? With a fresh Symfony install, or even installing PHP-Parser @dev or from master I can't reproduce.

Answer 5 · 2022-11-06T20:34:18.000Z

I have this in all my projects in Symfony 5.4 with the psysh bundle, but I tested it in a new Symfony project and I don't have the issue... 🤔

Anyway I worked on a fix for it and I have a PR for it.

Answer 6 · 2022-11-06T21:09:30.000Z

¯\_(ツ)_/¯ it can't hurt to add the return types, even if we can't repro anymore :)

Thanks for the fix!