Version 2.2.5 error
davidreghay opened this issue · 10 comments
First of all, I can't tell you how grateful I am to have this gem!
On to the issue. In the latest version I've discovered that events rendered a day prior to their actual start.
Also, the popover generated by an eventLimitClick is now empty.
By the way, although it's certainly not a bug, I don't like the fact that it the title now is (current_month - next_month). I think that can be confusing and that the old format was clearer.
Hi David! This gem is only a package containing FullCalendar; we're not the authors of FullCalendar itself. You'll find the correct project here: https://github.com/arshaw/fullcalendar
Please redirect your issue and the thanks (!) to Adam Shaw, the author of FullCalendar. :) Thank you!
Mysteriously enough, when I manually add the assets from https://github.com/arshaw/fullcalendar there isn't any problem. It specifically happens when loading them through the fullcalendar-rails gem (and only the latest one!) Even weirder, when I compare the contents of the respective fullcalendar.js files they are identical... And that's a shame, because I've really enjoyed being able to use this gem instead of loading scripts manually.
In light of this, I doubt that redirecting the issue to Adam Shaw is the right move here, as the bug doesn't seem to appear when fullcalendar is manually loaded.
Can anyone verify that this is the case? I suspect that you'll find the same to be true if you bundle update on any apps that make use of this gem vs loading the fullcalendar.js file manually.
Oh I'm sorry, but you forgot to mention that the bugs you're experiencing occur only when you use this gem in the first place, so I thought you are filing a bug report for FullCalendar itself! :)
I will look into this issue. My guess is that it's not related to fullcalendar.js but to one of the required gems (momentjs or jquery). Can you please check which versions of these reqirements are bundled in your app?
Sorry for the late response on this. Busy weekend.
Just found the answer! Your suspicion was correct and the issue was resulting somehow from the version of momentjs. I'm not sure exactly how or why, but momentjs v 2.8.3 does not play nicely with fullcalendar v 2.2.5. I think it has to do somehow with the fact that only in v 2.8.4 was added Support 24:00:00.000 to mean next day, at midnight.
Presumably up to fullcalendar v 2.2.3 this was somehow compensated for in event rendering but in v 2.2.5 it is deemed no longer necessary and so this discrepancy arose.
Ah, thank you! I will increase the required gem version for momentjs. :)
Uh, I can't... Its still at 2.8.3 but I contacted @derekprior and asked him to update it.
I noticed this also. That's life, I suppose. I was going to update it myself and make a pull request but I saw that @dbackowski has already done so.
Thanks for the help!
Update momentjs-rails to 2.8.4 and also 2.9.0
Thank you Derek! I will push the new version in a minute.