booyaa/wifiscanner

Switch to GitHub Action for lint, build and test

booyaa opened this issue · 6 comments

booyaa commented

No longer need to rely on 3rd party services like Travis, create a separate workflow file called ci.yml do not use any existing workflow if found.

See:

Acceptance criteria

Runs the following cargo commands on Linux and macOS (-latest virtual environment is sufficient)

  • check
  • fmt
  • test
  • clippy
b1zzu commented

Hi @booyaa can I work on this?

booyaa commented

Hi @booyaa can I work on this?

Yup go for it and thank you! Updated the issue to include acceptance criteria, let me know if you have any questions.

b1zzu commented

@booyaa we should tests on both linux and mac right?

booyaa commented

@booyaa we should tests on both linux and mac right?

Good spot, yup I've updated the acceptance criteria. Are you planning to use a strategy matrix to reduce code duplication? I've got an example if you've not used them before.

b1zzu commented

Yes I wanted to test check, fmt and clippy only on ubuntu with rust latest; and then use matrix to run the test against mac and ubuntu with rust latest, nightly and beta; wdyt?

booyaa commented