bramski/angular-indexedDB

Feature: Add ShimIndexedDB Support

Lunatic83 opened this issue · 7 comments

Hi Bramski
I'm using your angularjs indexeddb module for iOS support I had to fix putting the following code into
angular-indexed-db.js on line 15

indexedDB = window.indexedDB || window.mozIndexedDB || window.webkitIndexedDB || window.msIndexedDB || window.shimIndexedDB;

Do you think it could be possible to update your module with this fix, it will help me a lot in managing your library.

Thanks
Gaspare

What is shimIndexedDB?
On May 8, 2015 9:25 AM, "Gaspare Scherma" notifications@github.com wrote:

Hi Bramski
I'm using your angularjs indexeddb module for iOS support I had to fix
putting the following code into
angular-indexed-db.js on line 15

indexedDB = window.indexedDB || window.mozIndexedDB ||
window.webkitIndexedDB || window.msIndexedDB || window.shimIndexedDB;

Do you think it could be possible to update your module with this fix, it
will help me a lot in managing your library.

Thanks
Gaspare


Reply to this email directly or view it on GitHub
#31.

+1
https://github.com/axemclion/IndexedDBShim

is an implementation of indexedDB api over WebSQL, we use it in browsers that not support indexeddb natively, or where its implementation is poor. For example iOS Safari cordova webview ;)

eclipse1985 right.

Write a PR. I don't use Cordova and could never verify that this works.

Preferably such PR would include a harness that could run the existing testing in Safari Cordova. That way the functionality can be confirmed for those that want to use this plugin on cordova.

PR created. #33

Would prefer to keep the PR and the issues linked. Then everybody here can get informed when the issue is closed and the PR is merged.

Shim indexed DB support has been added.