brave/brave-rewards-ios

Hide Brave Rewards Icon

Closed this issue · 6 comments

In Settings, under OTHER SETTINGS, Sync, Brave Rewards, add a section called Display & Appearance

Here add the following:

Hide Brave Regards Icon
(sub text) Hides the Brave Rewards icon when Brave Rewards is not enabled

Toggle Switch On | Off
Default off

(see Android for formatting)

The option should be grey'ed out if Brave Rewards is enabled

Also,
Move Show Bookmark Shortcut into Display & Appearance and place it above Hide Brave Regards Icon

i.e.

Display & Appearance

Show Bookmark Shortcut
Hide Brave Regards Icon

@anthonypkeane Please add a screenshot of Android implementation

UPDATE

In Settings > Display & Brightness add the following under Display & Brightness

Show Bookmarks Shortcut (brave/brave-ios#1391)
Just move in here

Hide Brave Regards Icon
(sub text) Hides the Brave Rewards icon when Brave Rewards is not enabled

Toggle Switch On | Off
Default off

@jamesmudgett can you please confirm?

@anthonypkeane

You want the Show Bookmarks Shortcut put inside the Display & Brightness menu?

image

Confirming

Settings
General

Display
    Brightness 
    Show Tabs Bar
    Show Bookmarks Shortcut
    Hide Brave Rewards Icon

Brightness = the Automatic/Light/Dark options

Maybe we should follow Apple and call it "Appearance" instead of "brightness". Will almost certainly be weird if we diverge our brightness meaning from what iOS uses.

Appearance sounds fine with me