Not compatible with pg 7.50
Closed this issue · 2 comments
Equals182 commented
This module became incompatible with pg's 'minor' update 7.5.0.
Here you can see changes in query.submit
function - it now returns null
or Error
, while current pg-query-stream returns this
This basically breaks the whole streaming thing.
I believe returning null
should be enough to fix this issue.
brianc commented
Thanks! Sorry about that, will fix today.
…On Fri, Oct 5, 2018 at 8:59 AM Aleksandr ***@***.***> wrote:
This module became incompatible with pg's 'minor' update 7.5.0.
Here
<brianc/node-postgres@3828aa8#diff-32a8cfb1af74860f3233cd24dcd57fadR147>
you can see changes in query.submit function - it now returns null or
Error, while current pg-query-stream returns *this*
<https://github.com/brianc/node-pg-query-stream/blob/master/index.js#L24>
This basically breaks the whole streaming thing.
I believe returning null would be enough to fix this issue.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#46>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AADDoejyPq7Hdvwi96zRFcfhvUujr3uzks5uh2WwgaJpZM4XKSL4>
.
brianc commented
Pushed a new patch version w/ the fix!