int overflow when sample contains more reads than max int
Opened this issue · 2 comments
hepcat72 commented
This is basically the same issue as #14, but instead of the total read count, happens when an individual sample's read count exceeds the max int of: 2147483647.
In our case, it occurred specifically with unmatched output, but given the growth of single-cell sequencing analyses and technologies, it seems that ending up with real samples exceeding this max int is imminent.
hepcat72 commented
I'm running a one-time large test of my fix for this issue. It all goes as planned without a problem, I'll be submitting a PR tomorrow.
hepcat72 commented
Yep. Looks like my fix works. Prior to this fix, the unmatched output in the standard output was a nonsense negative number. Now:
...
Plate3_4D_F1_353_F_S3 29159 Plate3_4D_F1_353_F_S3_R1.fastq
Plate3_4E_F1_385_F_S1 27228 Plate3_4E_F1_385_F_S1_R1.fastq
Plate3_4F_F1_385_F_S2 25433 Plate3_4F_F1_385_F_S2_R1.fastq
Plate2_4F_F1_385_F_S3 30073 Plate2_4F_F1_385_F_S3_R1.fastq
unmatched 3220326335 unmatched_R1.fastq
total 3222124732
PR incoming. I just need to bump the minor version first.