bserdar/jcliff

Adding new connection properties support to datasources doesn't work

Opened this issue · 2 comments

mschoepke commented

jcliff 2.10.4 adds connection properties support for datasources, thanks for that. However, I can use jcliff only to modify existing connection-properties. Adding new ones doesn't work. It seems that both addConnProperties and modifyConnProperties2 rules are triggered:

      "connection-properties" =>
      {
        "cacheServerConfiguration" => { "value" => "true" },
      },

results in

2015-08-05 10:20:00:0751: modifyConnProperties2 will be run on add:/datasource/SomeReadDS/connection-properties/cacheServerConfiguration/value value="true"
2015-08-05 10:20:00:0752: run:/subsystem=datasources/data-source= SomeReadDS/connection-properties=cacheServerConfiguration:remove
/subsystem=datasources/data-source= SomeReadDS/connection-properties=cacheServerConfiguration:add(value="true")
2015-08-05 10:20:00:0752: Checking rule delete
2015-08-05 10:20:00:0752: Checking rule addConnProperties
2015-08-05 10:20:00:0752: addConnProperties will be run on add:/datasource/SomeReadDS/connection-properties/cacheServerConfiguration value={"value" => "true"}
2015-08-05 10:20:00:0753: run:/subsystem=datasources/data-source= SomeReadDS/connection-properties=cacheServerConfiguration:add(value="true")
2015-08-05 10:20:00:0753: Checking rule modify
2015-08-05 10:20:00:0753: Checking rule add
2015-08-05 10:20:00:0753: Checking rule modifyConnProperties
2015-08-05 10:20:00:0753: Checking rule removeConnProperties
bserdar commented

I see it. Problem appears to be a quirk in Widlfly configuration tree:
elements of connection-properties are defined with type UNDEFINED. I'll try
to find a workaround.

On Wed, Aug 5, 2015 at 2:30 AM, mschoepke notifications@github.com wrote:

jcliff 2.10.4 adds connection properties support for datasources, thanks
for that. However, I can use jcliff only to modify existing
connection-properties. Adding new ones doesn't work. It seems that both
addConnProperties and modifyConnProperties2 rules are triggered:

  "connection-properties" =>
  {
    "cacheServerConfiguration" => { "value" => "true" },
  },

results in

2015-08-05 10:20:00:0751: modifyConnProperties2 will be run on add:/datasource/SomeReadDS/connection-properties/cacheServerConfiguration/value value="true"
2015-08-05 10:20:00:0752: run:/subsystem=datasources/data-source= SomeReadDS/connection-properties=cacheServerConfiguration:remove
/subsystem=datasources/data-source= SomeReadDS/connection-properties=cacheServerConfiguration:add(value="true")
2015-08-05 10:20:00:0752: Checking rule delete
2015-08-05 10:20:00:0752: Checking rule addConnProperties
2015-08-05 10:20:00:0752: addConnProperties will be run on add:/datasource/SomeReadDS/connection-properties/cacheServerConfiguration value={"value" => "true"}
2015-08-05 10:20:00:0753: run:/subsystem=datasources/data-source= SomeReadDS/connection-properties=cacheServerConfiguration:add(value="true")
2015-08-05 10:20:00:0753: Checking rule modify
2015-08-05 10:20:00:0753: Checking rule add
2015-08-05 10:20:00:0753: Checking rule modifyConnProperties
2015-08-05 10:20:00:0753: Checking rule removeConnProperties

—
Reply to this email directly or view it on GitHub
#55.

bserdar commented

No luck. There is a problem removing properties once they're added, and there is no way to modify them. I opened this:

https://issues.jboss.org/browse/WFLY-5073

Lets see what they say.

in the mean time, I changed the rules to support adding new connection properties, so that should work. Modifying connection properties won't work until this is fixed, or until I find a workaround.