Uplift to core

[clokep]

"The Mozilla core supports setting the overlay, but the bug for actually making Thunderbird do so has languished for about four years. Sigh."

Any reason you haven't put a patch on the bug yourself? Looking over your code it seems like it is already pretty polished.

[bstreiff]

The initial version I released (which was 1f69490) was the first time I'd written anything with a significant amount of JavaScript, so it was in large part a learning exercise, and not anywhere near a quality level that I'd feel comfortable trying to promote it to core. (That version hand-blit prerendered font images to an array I was using to act as an image buffer! It was super ugly.)

Now that I've iterated on it quite a bit-- both learning better JS idioms (namespacing, etc) and getting a better handle on what's available in the Mozilla frameworks (constructing canvas elements as offscreen drawing surfaces, for example) it's in much better shape.

Getting it into core would be nice, though. When I next have a good chunk of time available I'll look into the guidelines and process for patch submission.

[clokep]

Well, the JS looks pretty good. If you want to attach a patch and get an
initial review, I'm more than willing to do it. Someone else will need to
do the final review (I'm a Peer of a Thunderbird module, but not the one
this would be a part of). Thanks for the extension!

On Sun, Jan 12, 2014 at 5:41 PM, Brandon Streiff
notifications@github.comwrote:

The initial version I released (which was 1f694901f69490)
was the first time I'd written anything with a significant amount of
JavaScript, so it was in large part a learning exercise, and not anywhere
near a quality level that I'd feel comfortable trying to promote it to
core. (That version hand-blit prerendered font images to an array I was
using to act as an image buffer! It was super ugly.)

Now that I've iterated on it quite a bit-- both learning better JS idioms
(namespacing, etc) and getting a better handle on what's available in the
Mozilla frameworks (constructing canvas elements as offscreen drawing
surfaces, for example) it's in much better shape.

Getting it into core would be nice, though. When I next have a good chunk
of time available I'll look into the guidelines and process for patch
submission.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1#issuecomment-32136677
.

[abcminiuser]

I agree, this should make its way to the core, especially now that the duplicate counting has been resolved. I suppose some settings UI might be warranted for the RSS filtering however, as perhaps someone actually wants those included.

[bstreiff]

I just learned today that, thanks to the generous work of Ping Chen, the bulk of this extension has been integrated into core as part of bugzilla bug 715799, and should, as far as I can tell, be in Thunderbird 91.

As such, I will freeze and archive this repo when Thunderbird 91 releases, and any further bugs or changes should be filed with the upstream Thunderbird team.

Thank you to everyone who has used this extension, contributed bugfixes, and put up with my glacial release cycles after all these years. ❤

[homo-programmatis]

Congratulations and thanks for your hard work!