btcsuite/btcscript

sigDer belongs in btcec as an exported function

donovanhide opened this issue · 2 comments

donovanhide commented

Hi,

I'm using btcec for a Ripple node implementation and I'm wanting to send DER encoded ECDSA signatures to other nodes. This function perhaps belongs in btcec?

https://github.com/conformal/btcscript/blob/d4c5b3d04d49097c0f17c81d29c183f4a1593f6c/script.go#L1028-L1069

Thanks for the incredibly useful code!

Cheers,
Donovan.

davecgh commented

I agree with this and after discussing with @owainga he does as well. I'll be moving this to btcec shortly. The name will change to Serialize and will be a function on the btcec.Signature type so it fits into the btcec API better.

donovanhide commented

Excellent! Thank you very much!

On 23 December 2013 15:02, Dave Collins notifications@github.com wrote:

I agree with this and after discussing with @owaingahttps://github.com/owaingahe does as well. I'll be moving this to btcec shortly. The name will change
to Serialize and will be a function on the btcec.Signature type so it fits
into the btcec API better.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/3#issuecomment-31123185
.