buckwilson/Lightbox_me

IE8 - escape and vertical issue

Opened this issue · 5 comments

Hi

I have a couple of IE8 issues, which you can see on the demo page:
http://buckwilson.me/lightboxme/

  1. a vertical scrollbar appears when it should not (you have to zoom out a long way on this page to hit this, but it's a real issue for me on a normal page without zooming)
  2. escape is not causing a close

I fixed (1) on line 155 by deducing 4 from the height calculation.
$overlay.css({height: $(document).height()-4 + 'px'});
4px was the smallest value which resolved it, and I've not noticed anything bad on other browsers (latest mac ff, safari, chrome).

I fixed (2) by changing the bindings on line 93 and lines 133-136 to be to $self from $(window).

I don't know whether these fixes are 'right' but thought I would share.

Thanks so much for calling these to my attention. I'll run some tests
on your changes and bundle them with a couple of changes I have and
release as soon as I can.

Thanks again!

  • Buck

On Sunday, June 26, 2011, damonmannion
reply@reply.github.com
wrote:

Hi

I have a couple of IE8 issues, which you can see on the demo page:
http://buckwilson.me/lightboxme/

  1. a vertical scrollbar appears when it should not (you have to zoom out a long way on this page to hit this, but it's a real issue for me on a normal page without zooming)
  2. escape is not causing a close

I fixed (1) on line 155 by deducing 4 from the height calculation.
$overlay.css({height: $(document).height()-4 + 'px'});
4px was the smallest value which resolved it, and I've not noticed anything bad on other browsers (latest mac ff, safari, chrome).

I fixed (2) by changing the bindings on line 93 and lines 133-136 to be to $self from $(window).

I don't know whether these fixes are 'right' but thought I would share.

Reply to this email directly or view it on GitHub:
#23

BTW, lines 96 and 136 are inconsistent, 136 should unbind keyup

Good call, fixing that today.

Escape issue has been checked in, still looking into the vertical issue.

Was this ever released? I am still having issues with IE8 and pressing escape to close.