Use a Rust-based hex float parser

Question

Use a Rust-based hex float parser

Closed this issue 5 years ago · 4 comments

Hex float parsing is delegated to the C standard library right now but this exposes us to platform differences (like failing tests only on macOS). We should reimplement this in Rust. Crates like https://crates.io/crates/hexf-parse seem promising but don't work immediately. Needs more investigation.

Answer 1 · 2019-10-15T23:32:43.000Z

Right now we use strtod and strtof, which I thought wabt used as well, but turns out they have their own hex float parser. Perhaps this can translate that!

Answer 2 · 2019-10-16T21:54:07.000Z

Looks like strtod and strtof are way off on MinGW as well, so yet another reason to use one canonical version instead of whatever the system happens to have.

Answer 3 · 2019-10-18T00:27:43.000Z

In case it helps, mozilla-central has another one.

Answer 4 · 2019-10-18T17:06:08.000Z

Thanks for the link @sunfishcode!

I was able to muster up enough energy and the was digestable enough this it ended up working!