Implement the GC proposal
Closed this issue · 4 comments
I've now gotten wat integrated and passing our test suite in SpiderMonkey. Thanks for the quick resolution of issues!
The remaining blocker to landing this is to support the experimental GC syntax. I'm not sure what the canonical documentation for this is. It's either our implementation, Lars' documentation, or the GC repo. @lars-t-hansen do you know?
I'm happy to implement this, just wanted to provide a heads up.
Since people are depending on the syntax we support in SpiderMonkey, using my documentation (which should be effectively identical to what we implement) is best for the time being. This can be allowed to change over time, but the GC proposal is very slow moving and in a very early stage, and it's best to duplicate what we have for now.
Sounds good to me! If you need any pointers @eqrion just lemme know, happy to help out around the code.
In terms of tests almost all tests right now are reference checks against wabt, and I don't think wabt implements the GC proposal. In that sense if you add *.wat or *.wast files the test suite will ensure that they parse and generate a binary, but basically just without panics.
If you want to specifically test the binary encoding that'll be a bit harder, but it's fine to not have tests for that.
Ben Smith just posted a WIP PR for GC support in Wabt: WebAssembly/wabt#1345
Oh nice, excellent timing :)