[PHONE_CONVERSATION][PROVIDERS][RAPIDS] feature calculation bug.
Closed this issue · 2 comments
yiyir commented
Describe the bug
In /rapids/src/features/phone_conversation/rapids/main.py line 11:
Calculation of expected total duration assumes that the length of the current time segment is 1 day (1440 minutes).
Features related: silenceexpectedfraction, noiseexpectedfraction, voiceexpectedfraction, unknownexpectedfraction
Expected behavior
Should not hardcode the length of the time segment(avoid magic numbers like 1440); instead, infer from the “length” column of time_segment.csv file
JulioV commented
Thanks Yiyi, @nikunjgoel95 can you take a look at this, please?