carrascoacd/ArduinoSIM800L

readBuffer & readSignalStrength

pixelfriese opened this issue · 1 comments

pixelfriese commented

Hi,

can someone verify the following two things:

In the readBuffer function, >= should be used instead of > in the following two places. Without this change I get an error message and the ESP32 reboots: "Stack smashing protect failure!"

ArduinoSIM800L/src/Sim800.cpp

Line 70 in f4f40b9

if (i > count - 1)

ArduinoSIM800L/src/Sim800.cpp

Line 73 in f4f40b9

if (i > count - 1)

Another thing is the readSignalStrength function. Returning AT+CSQ is much shorter. The length of the buffer should be 24 instead of 32. Without this change, the readBuffer function runs into timeout:

ArduinoSIM800L/src/Http.cpp

Line 163 in f4f40b9

char buffer[32];

carrascoacd commented

Thanks for your issue @pixelfriese. Do you mind creating a PR with the changes that you suggest so I can check them?