No SRT files created message
Closed this issue · 29 comments
Seem to get a no SRT files created when it does create the files and the their are subtitles.
Using GUI V0.2.108
Hi! What size are the files. Are they zero bytes?
If they are zero bytes the OCR library is returning no subs. I have opened an issue with the author of that library. Subs are complicated especially from BD3D. They are in an image format which isn't used anymore. I don't believe I can convert to an image format that MV-HEVC will use, so I have to convert them to text with the pgsrip library. I am open to other solutions!
Odd, so it's a different issue. Are there any non ascii characters in the filename? Just a FYI, I think checking continue on error should allow it to continue, and since they are valid they should be added to the output. It should be seeing those files and NOT give you an error.
if not any(output_path.glob("*.srt")) and not skip_or_continue:
raise SRTCreationError("No SRT subtitle files created.")
@cbusillo This is the file name Pirates.of.the.Caribbean.Dead.Men.Tell.No.Tales.2017.mkv
I cannot figure out how you would get this error while there are srt files with data in them. Have you tried it a second time to see if it was a transient issue? Did you try with "Continue Processing on Error" to see if the subs wind up in the final video? Have you been able to successfully encode other videos with this version? Thank you!
I am getting the same error on some ISO files that have subtitles. Normally not a big deal, but this one is a French film so English subtitles are a must for me, hahaha
@mikemonello are there srt files? if so how large are they?
@cbusillo I have tried two movies with the same effect, the video encodes correctly just with no subtitles even though it successfully extracts them in the step before.
@edeuss are you ripping to and from the internal drive, an external drive, or a network drive? Also I didn't notice you answering if the sups are in the final video when you select continue on error. Everything looks right in the code and it works for me. I cant think of any reason it wouldn't find the *.srt files in the output_folder. Can I have a screen shot of the full app window so I can see all of the settings, just in case that will help me?
Adding a new prerelease, it should be ready in 20 minutes. It changes the detection method, but also adds a bit of debugging text.
Running Sup subtitles extraction and SRT conversion
Checking for .srt files in: /Users/cbusillo/TEMP/Blu-Ray
Found .srt file: title_t00.en.srt
Finished Sup subtitles extraction and SRT conversion in 57 seconds
Running FRIM to split MVC to stereo. 🌖
@edeuss are you ripping to and from the internal drive, an external drive, or a network drive?
From an internal drive through makemkv.
Also I didn't notice you answering if the sups are in the final video when you select continue on error.
Thin this comment I said that once continuing the video encoded fine but there was no subtitle attached.
Can I have a screen shot of the full app window so I can see all of the settings, just in case that will help me?
Just using the default settings.@cbusillo I think I do have an idea of what the issue is though. When its going though the process and it creates a temp folder, these .srt's are not in that. They are in the same folder as the source .mkv, so maybe it's looking for them in the temp folder instead of where they are.
@edeuss, thank you, I misinterpreted that message. I notice this one has symbols in the filename, that shouldn't matter and you also had issues with a "normal" filename.
It is (should be) looking in the correct place, the temp folder was to move all of the temporary files out of the main drive, just in case they were large. The issue did seem to start around that time though, so I'll keep looking at it.
Did you happen to update to at least prerelease v0.2.113? I added some path information in the output so we can figure this out.
I received the following error using v0.2.113. For this one, I ripped both 3DBDs to MKV using MakeMKV, then merged the files into 1 3D MKV. I then used the app to convert that file, but I did verify the subtitles worked in VLC before running the conversion.
🟢 Processing started at 11:49:53 PM on 2024-06-20 🟢
Processing /Volumes/Movespeed2TB_SSD/MakeMKVTests/Titanic3D_merged.mkv
Running Get disc and MVC video properties
Finished Get disc and MVC video properties in a moment
Detecting crop parameters...
Running ffmpeg to extract video, audio, and subtitles from MKV
Finished ffmpeg to extract video, audio, and subtitles from MKV in 16 minutes
Running Sup subtitles extraction and SRT conversion
Checking for .srt files in: /Volumes/3DAVP_Movies/BD_To_AVP_GUI_OUTPUT/Titanic3D_merged
No .srt files found in /Volumes/3DAVP_Movies/BD_To_AVP_GUI_OUTPUT/Titanic3D_merged
No SRT subtitle files created.
❌ Processing failed in an hour ❌
🛑 Processing stopped after an hour 🛑
@mikemonello I didn’t notice an answer earlier, are those files bigger than 0 bytes? I’m trying to make sure this is the same issue. I’m not sure why I am not having the same issue. Can you give a screenshot of the Titanic3D_merged folder? Also just out of curiosity @edeuss what are some reasons you rip to MKV first? I understand Mike’s reason here, since there are two discs.
I'm going to install vo.2.114 and try again, but here's a screenshot of the folder. No .srt files were there, and the tmp folder is empty.
Just found them! I went to run a new rip and the .srt files were in the folder where the source MKV file was, not in the output folder.
Both files have data in them:
I misread @edeuss's statement above. Thank you @mikemonello, I will figure out what's going on now that I can see it.
You two are using mkvs as sources. I think that may be causing the issue. I always start with an iso.
Sorry for not understanding! MKVs are handled slightly differently since they are basically a stage two, but we need some info from stage one. pgsrip doesn't allow me to specify an output folder, it outputs in the source folder. For ISOs thats fine since the mkv is created in the working folder. I should be able to push a fix out for this shortly.
I did select the option to start on step 2 after the MKV rip, since I had already done that.
I think v0.2.115 will fix it when it comes out. If anyone has time to test on a MKV, please let me know. That was the issue. Also @mikemonello FYI, you can use stage 1 or 2. I basically does the same thing if the input is a MKV. Thank you both for helping me thought this one.
@edeuss what would you expect them to be named? Do you have examples of ones you think are named correctly?
I keep getting this same hangup. The icon isn't animating, and it's been at this stage for almost 2 hours. The app hasn't crashed, it's responsive to the system, it just seems stuck.
You keep getting it as in you are getting it on just this movie, or multiple movies? Can you should me the Titanic 3D folder?
I noticed this is a video you "merged". does the same thing happen on the individual ISOs? @mikemonello?
This should be fixed, MKVs as source have the srt files created in the source folder instead of destination. Moving them to output folder fixed issue