celestiaorg/go-square

Issues

• inclusion: SubtreeWidth should define what happens when subtreeRootThreshold<=0 else a divide by zero panic on

  #120 opened 4 months ago by odeke-em
  2

• share: builder.WriteSequenceLen needs bounds checks for .rawShareData lest encounter a panic; perhaps add a validation to fail on immediate constructor invocation

  #121 opened 4 months ago by odeke-em
  0

• inclusion, all: RoundDownPowerOfTwo and RoundUpPowerOfTwo are very inefficient and can cause running out of RAM due to an integer overflow

  #117 opened 4 months ago by odeke-em
  0

• share: NewShare should return value instead of pointer

  #116 opened 4 months ago by Wondertan
  0

• porposal: introduce `Commitment` method on `share.Blob`

  #114 opened 4 months ago by Wondertan
  3

• merkle: innerHash dominates CPU/RAM consumption by sha256.Sum256(append(bytes...)) but it can be further sped up and allocations reduced as well by using a pool and reusing hashes

  #43 opened 5 months ago by odeke-em
  4

• Canonicalise Namespace and Share types

  #66 opened 6 months ago by cmwaters
  1

• Consider adding RowProof to this repo

  #100 opened 7 months ago by rootulp
  0

• Add different types of validation methods to blob

  #69 opened 7 months ago by cmwaters
  2

• Consider renaming blob proto package

  #33 opened 7 months ago by rootulp
  0

• Pre-verify blobs once instead of twice

  #77 opened 7 months ago by evan-forbes
  0

• refactor: remove compact and spare shares

  #30 opened 2 years ago by rootulp
  2

• This repo shouldn't maintain Merkle tree implemenation

  #39 opened 8 months ago by Wondertan
  2

• Change shares package name to share

  #88 opened 8 months ago by cmwaters
  0

• Validate the namespace in the Share constructor

  #86 opened 8 months ago by cmwaters
  0

• Add benchmarks to share encoding / decoding

  #81 opened 8 months ago by cmwaters
  0

• Merge namespace and blob packages into shares

  #79 opened 8 months ago by cmwaters
  0

• When parsing shares, check that all shares belong to the same namespace

  #78 opened 8 months ago by cmwaters
  1

• Add a local blob type

  #70 opened 8 months ago by cmwaters
  0

• Pass app version to `CreateCommitment` and `NewMsgPayForBlobs`

  #37 opened 8 months ago by evan-forbes
  5

• Make `ShareProof` types available in go-square

  #55 opened 10 months ago by damiannolan
  3

• docs: update the spec with how square construction is currently implemented

  #50 opened 2 years ago by cmwaters
  2

• Enable dependabot

  #21 opened 9 months ago by rootulp
  8

• Consider renaming `CompactShareReservedBytes` to `ShareReservedBytes`

  #38 opened 9 months ago by rootulp
  1

• Consider using the share version to differentiate compact and sparse shares

  #60 opened 2 years ago by rootulp
  9

• Add diagrams to README

  #17 opened a year ago by rootulp
  0

• Consider removing reserved bytes from the first compact share

  #36 opened 2 years ago by rootulp
  0

• bug: worst case share indexes uses max square size

  #47 opened a year ago by rootulp
  2

• inclusion: RoundUpByMultipleOf and all other modulo denominator must be checked for zero before usage

  #45 opened a year ago by odeke-em
  1

• Clarify this repo applies to original data square

  #25 opened a year ago by rootulp
  0

• shares: NamespacePaddingShare can take advantage of Go's memory guarantees to zero memory and use make([]byte, LEN) instead of bytes.Repeat([]byte{0}, LEN) which is less efficient

  #41 opened a year ago by odeke-em
  0

• shares: powersOf2 test should put less expensive comparison before AND and SUBTRACTION

  #40 opened a year ago by odeke-em
  1

• Consider introducing a type alias for `NamespaceVersion`

  #35 opened 2 years ago by rootulp
  5

• Move and link specs

  #15 opened a year ago by cmwaters
  4

• Add a license

  #26 opened a year ago by rootulp
  0

• Consider enabling go-critic

  #18 opened a year ago by rootulp
  2

• Path to publishing Go modules from this repo

  #20 opened a year ago by rootulp
  1

• Add command to generate Go types from `.proto` files

  #13 opened a year ago by rootulp
  2

• Blob commitment uses hard coded subtree root threshold

  #5 opened a year ago by cmwaters
  3

• Add readme

  #7 opened a year ago by cmwaters
  0

• Consider removing `FitsInSquare`

  #4 opened a year ago by rootulp
  0

• Setup CI workflows

  #6 opened a year ago by cmwaters
  0