cellgeni/sceasy

Converting SCE to LOOM obs and var attribute names

SimonDMurray opened this issue · 1 comments

Hi,
I was recently trying to convert an SCE object to loom and I noticed the sce2loom function contains the line:
colnames_attr = "obs_names", rownames_attr = "var_names"
which I changed to:
colnames_attr = "CellID", rownames_attr = "Gene"
in order to get my downstream analysis to work.

I was curious if there was a reason you did this as LOOM documentation suggests "CellID" and "Gene"?

Thanks in advance!
Simon

nh3 commented

Sorry for the late reply. Thank you for bringing this to attention. It was an outdated decision/piece of code. Happy to change to "CellID" and "Gene" in the next release. A PR would be highly welcome. :)