Unshared members can overwrite inherited unshared members
Closed this issue · 2 comments
unshared members get a generated name based on a simple incrementing sequence.
With enough bad luck, a type can get a name for a non-shared member that is identical to a name already in use by an inherited member. This already happened with List in the language and LinkedList in the SDK.
This can only happen with type members, so a solution is to add something to the names of non-shared type members, for example the hash of the type's qualified name. That way, two types with the same name in different modules will most likely have different hashcodes so their non-shared members will not collide. And even if a type satisfies a whole lot of types from a bunch of different modules (including its own), and one or more of those types have the same hashcode, a collision only occurs if they also have non-shared members with the same generated name.
As @jvasileff pointed out, using the module's qualified name as a prefix means only one prefix per module, which is already safe as the counter for generated names is unique per module. So fewer prefixes are generated which mean lower chance of collision.