chaldea-center/chaldea

[Bug] GitHub backup token input is limited to 40 characters

Closed this issue · 6 comments

What happened?

The input field for token in GitHub backup screen is limited to 40 characters.
image
This causes fine-grained personal access tokens to be trimmed and don't work, since that token is longer, eg github_pat_xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

Note that fine-grained personal access token is supported by the file contents api as linked from the github backup page: https://docs.github.com/en/rest/repos/contents?apiVersion=2022-11-28#create-or-update-file-contents

Platform

All

Device Info

No response

Which game server is related to this issue? (Optional)

No response

App Version

2.5.10 (971) - 9381d2

Checklist

Relevant log output

No response

Does the fine-grained PAT have fixed length or any pattern to validate?

I cannot find any official conclusive doco on the access token format or length, but having generated a few tokens they seem to be 93 characters and start with github_pat_

sorry forgot this issue, does 93 chars include the github_pat_ prefix

Yes, 93 characters includes the github_pat_ prefix

try beta when new build finished

Thanks, it's working perfectly now