chaoss/grimoirelab-manuscripts

The data and figs for the report creation are copied recursively

acs opened this issue · 9 comments

acs commented

In each generation of a report the data and figs folders used to create the PDF report file are copied recursively. For example:

(acs@dellx) (quarters-titles % u=) ~/devel/grimoirelab-manuscripts-fork-acs $ ls -l bitergia-servers/opnfv/report_data/figs/figs/data/figs/data
total 804
drwxrwxr-x 2 acs acs   4096 mar  1 14:40 activity
....

@jgbarah shall i take this? I figured out the bug

@f2014169 go ahead if you feel like that...

@acs @jgbarah please visit #30

acs commented

@acs @jgbarah please visit #30

Hmm, it is not clear for me what to do in #30. Please. to work in this bug open a specific PR that address it. Thanks you @f2014169

@acs: #30 is about a different stuff, explained in that pr. Please, add your review there if you don't mind.

acs commented

@acs: #30 is about a different stuff, explained in that pr. Please, add your review there if you don't mind.

Yes, I know it, but I need to find what change about all of them is related to this issue. And after the review, the code can not be merged from there if we want a clean merge.

If it is not possible to get the commit related to this issue #24 and create a PR specific for it, I would try to do the review in #30. Could you specify which is the specific commit in #30? I suppose it is: #30 (comment) but I can not find code fixing current issue #24.

I see now. It seems #30 includes code for both the logo stuff, and the recursive copy stuff. I've found the code for the latter in it, and reviewed it asking to be moved to a new pull request. Thanks, @acs.

@acs @jgbarah i've removed code for #24 from #30 ,ill create seperate pull request

@acs @jgbarah please review my opened pr once you get some time :)