/untangle-your-spaghetti-test-code

Primary LanguageJavaApache License 2.0Apache-2.0

Untangle Your Spaghetti Test Code

Build Sonar Quality Gate Sonar Coverage

Open in Gitpod

Agenda

When What
14:45 Welcome: what we do, setup, code
15:55 Together: review the code base
15:05 Brainstorming: about problems
15:20 Untangle the code
15:30 Coffee break
16:00 Ensemble: untangle the code continued
16:35 Retro
16:45 The end

Todo

  • Agenda
  • Prepare Repl or other (Christian)
  • Cheat sheet
    • Arrange Act Assert (Micha)
    • Test Data Builder Pattern (Micha)
    • Expressive test case/variable naming (Micha)
    • Database Stub/Test database setup util (Micha)
    • …
  • Prepare retro (Micha)

Setup

  • Create an account on github: github.com/join
  • Follow this link and follow the instructions
  • Open src/test/java/com/agiletestingdays/untangletestcode/unicornservice/UnicornServiceApplicationTests.java from the file tree on the left and wait for the Java installation to finish

Objectives

  1. Have a look at the UnicornServiceApplicationTest. Which problems do you see?

    • Do you understand what's being tested?

    • Is there a proper arrange, act, assert structure in the test cases?

    • Are the names of test cases and variables consistent?

      Does it help to understand implications of failures?

      Does it help to find the corresponding code?

    • Do you understand how the test works technically?

    • Which layer of the testing pyramid is this test on?

      Is the layer appropriate for the test cases?

    • Do you see where the test data is coming from?

    • Which code duplications do you find?
      How would you reduce them?

  2. Let's untangle it!

    • Apply a consistent naming scheme

      Suggestion: <classUnderTest>Test.<methodUnderTest> [<happyCaseDiffStateUnderTest>] (see How to Name Tests for Maintainability)

    • Create a UnicornTestDataBuilder to reduce the arranging code in all the test cases with it and to make the differences between the arrangements obvious.

    • Replace the data.sql with arranging code in your test cases.

    • Push the validation tests down to UnicornControllerTest

      The "invalid unicorn test cases" can be tested far more efficiently on a lower level of the testing pyramid. Keep only one happy and one invalid case in UnicornServiceApplicationTest to test the overall behavior.