claudeheintz/LXESP32DMX

Removing the need to mod esp32-hal-uart

Closed this issue · 2 comments

seymar commented

First of all thank you for your great efforts in creating this library! 👍

However modding the code from the core kinda makes me scratch my head.
Wouldn't it be possible to just copy the functionality of esp32-hal-uart and changing it as required?

kbickham commented

I have a wroom-32 properly configured...and can't get the hardware uart to output anything besides the serial monitor in the arduino ide (though usb).

claudeheintz commented

The need to modify the esp32-hal-uart file is only for DMX input. If you are using the library to transmit DMX, it is not necessary. The reason that the mod is required is because RTOS places incoming bytes in a queue. The only way to signal a break is to use a scheme like SLIP to encode the start/end of packets. This is pretty specialized behavior. So, its unlikely that it would be included in the esp32 library as a pull request. Hence the need to modify the esp32-hal-uart file for the purposes of receiving DMX. (I don't believe that the modified uart function is in an exposed class, so using an override was not an option).

  • 👍1