cliftonc/calipso

mongoose version

laurelnaiad opened this issue · 2 comments

Sorry for the noise, but I'm running into more mongoose compatibility issues.

https://github.com/cliftonc/calipso/blob/master/lib/core/Table.js#L167 says:

      qry = qry.sort(sortArr[0], dir);

which is also outdated. See http://stackoverflow.com/questions/4299991/how-to-sort-in-mongoose , for instance.

So I guess the question is whether or not the intent is to support 3.6.x or some other version. Perhaps earlier versions, including the one that the calipso developer(s) have installed already, had support for the syntax that is breaking now? When I ran the install I got mongoose "version": "3.6.20". I'll hold off on additional PRs for these things because it seems to be somewhat pervasive and perhaps the intent wasn't to allow newer versions of Mongoose (yet)? Please let me know. I'll be fixing as I go locally and would like to be able to contribute.

The intent was to support the new version since the old one doesn't work on
smartos. I did as much testing as I could, thanks for the findings.
Andy

Sent from my iPhone

On Sep 26, 2013, at 4:26 PM, Stu Salsbury notifications@github.com wrote:

Sorry for the noise, but I'm running into more mongoose compatibility
issues.

https://github.com/cliftonc/calipso/blob/master/lib/core/Table.js#L167 says:

  qry = qry.sort(sortArr[0], dir);

which is also outdated. See
http://stackoverflow.com/questions/4299991/how-to-sort-in-mongoose , for
instance.

So I guess the question is whether or not the intent is to support 3.6.x or
some other version. Perhaps earlier versions, including the one that the
calipso developer(s) have installed already, had support for the syntax
that is breaking now? When I ran the install I got mongoose "version":
"3.6.20". I'll hold of on PRs for these things because it seems to be
somewhat pervasive and perhaps the intent wasn't to allow newer versions of
Mongoose (yet)? Please let me know. I'll be fixing as I go locally and
would like to be able to contribute.


Reply to this email directly or view it on
GitHubhttps://github.com//issues/224
.

Ok, thanks. I'll keep the PRs coming as I find them.