Weather is broken due to Yahoo weather API changes
PeterSumm opened this issue · 28 comments
PeterSumm commented
I loved this for about a week, but then Yahoo changed their API and it died. Before I jump into the code to try to fix it, is anyone working on this?
cmspooner commented
I have a fix that I'm testing in the beta:
https://gam.fitbit.com/gallery/clock/aa2ef146-e1c9-403c-a17b-0011ceec7d12
I had to remove the 3 day forecast for the time being since I need to do
some engineering to make it work with openweathermap.
Let me know if you have any errors, or lower-case weather.
I will push my current code up today. Also see if you can find the date
error. It only updates the dat on load.
…On Thu, Jan 10, 2019, 2:31 AM PeterSumm ***@***.*** wrote:
I loved this for about a week, but then Yahoo changed their API and it
died. Before I jump into the code to try to fix it, is anyone working on
this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA8pt8YnaU0JVJwH6ywHJ_7FfaDJSA2Jks5vBuxagaJpZM4Z47uh>
.
helmsd29505 commented
Chris
I’ll install the new version and test some. I’ll let you know how it goes. I’ve decided to take this opportunity to expand my watch face(ShmackAnalog). I’ve built a test run that I’m personally running. I went back through the weather and expanded the other options (dark sky, underground, and open weather). Currently I’m running hard coded key and open weather. Everything seems to be working well. (Thanks for the suggestion) The plan is to add option for user to choose which source they want, and provide their own key. If I get this done soon I’ll see what I can do with the forecasting and I’ll send you my findings. Best of luck to you.
Donald Helms
________________________________
From: Chris Spooner <notifications@github.com>
Sent: Thursday, January 10, 2019 06:01
To: cmspooner/ForecastTime
Cc: Subscribed
Subject: Re: [cmspooner/ForecastTime] Weather is broken due to Yahoo weather API changes (#1)
I have a fix that I'm testing in the beta:
https://gam.fitbit.com/gallery/clock/aa2ef146-e1c9-403c-a17b-0011ceec7d12
I had to remove the 3 day forecast for the time being since I need to do
some engineering to make it work with openweathermap.
Let me know if you have any errors, or lower-case weather.
I will push my current code up today. Also see if you can find the date
error. It only updates the dat on load.
On Thu, Jan 10, 2019, 2:31 AM PeterSumm ***@***.*** wrote:
I loved this for about a week, but then Yahoo changed their API and it
died. Before I jump into the code to try to fix it, is anyone working on
this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA8pt8YnaU0JVJwH6ywHJ_7FfaDJSA2Jks5vBuxagaJpZM4Z47uh>
.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#1 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AngjPmCvG0ICv708q_Z8RZeZhHa5eKvoks5vBx1sgaJpZM4Z47uh>.
cmspooner commented
FYI l, Technically users providing Thier own key is against the tos for
most providers.
…On Thu, Jan 10, 2019, 6:32 AM helmsd29505 ***@***.*** wrote:
Chris
I’ll install the new version and test some. I’ll let you know how it goes.
I’ve decided to take this opportunity to expand my watch
face(ShmackAnalog). I’ve built a test run that I’m personally running. I
went back through the weather and expanded the other options (dark sky,
underground, and open weather). Currently I’m running hard coded key and
open weather. Everything seems to be working well. (Thanks for the
suggestion) The plan is to add option for user to choose which source they
want, and provide their own key. If I get this done soon I’ll see what I
can do with the forecasting and I’ll send you my findings. Best of luck to
you.
Donald Helms
________________________________
From: Chris Spooner ***@***.***>
Sent: Thursday, January 10, 2019 06:01
To: cmspooner/ForecastTime
Cc: Subscribed
Subject: Re: [cmspooner/ForecastTime] Weather is broken due to Yahoo
weather API changes (#1)
I have a fix that I'm testing in the beta:
https://gam.fitbit.com/gallery/clock/aa2ef146-e1c9-403c-a17b-0011ceec7d12
I had to remove the 3 day forecast for the time being since I need to do
some engineering to make it work with openweathermap.
Let me know if you have any errors, or lower-case weather.
I will push my current code up today. Also see if you can find the date
error. It only updates the dat on load.
On Thu, Jan 10, 2019, 2:31 AM PeterSumm ***@***.*** wrote:
> I loved this for about a week, but then Yahoo changed their API and it
> died. Before I jump into the code to try to fix it, is anyone working on
> this?
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#1>, or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AA8pt8YnaU0JVJwH6ywHJ_7FfaDJSA2Jks5vBuxagaJpZM4Z47uh
>
> .
>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<
#1 (comment)>,
or mute the thread<
https://github.com/notifications/unsubscribe-auth/AngjPmCvG0ICv708q_Z8RZeZhHa5eKvoks5vBx1sgaJpZM4Z47uh
>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA8pt-TehP4LIYRcbc0tI3t1hUggpEayks5vByTQgaJpZM4Z47uh>
.
helmsd29505 commented
That was actually suggested by open weather maps support team. But I’ll check on that.
Thanks
Donald Helms
________________________________
From: Chris Spooner <notifications@github.com>
Sent: Thursday, January 10, 2019 07:20
To: cmspooner/ForecastTime
Cc: helmsd29505; Comment
Subject: Re: [cmspooner/ForecastTime] Weather is broken due to Yahoo weather API changes (#1)
FYI l, Technically users providing Thier own key is against the tos for
most providers.
On Thu, Jan 10, 2019, 6:32 AM helmsd29505 ***@***.*** wrote:
Chris
I’ll install the new version and test some. I’ll let you know how it goes.
I’ve decided to take this opportunity to expand my watch
face(ShmackAnalog). I’ve built a test run that I’m personally running. I
went back through the weather and expanded the other options (dark sky,
underground, and open weather). Currently I’m running hard coded key and
open weather. Everything seems to be working well. (Thanks for the
suggestion) The plan is to add option for user to choose which source they
want, and provide their own key. If I get this done soon I’ll see what I
can do with the forecasting and I’ll send you my findings. Best of luck to
you.
Donald Helms
________________________________
From: Chris Spooner ***@***.***>
Sent: Thursday, January 10, 2019 06:01
To: cmspooner/ForecastTime
Cc: Subscribed
Subject: Re: [cmspooner/ForecastTime] Weather is broken due to Yahoo
weather API changes (#1)
I have a fix that I'm testing in the beta:
https://gam.fitbit.com/gallery/clock/aa2ef146-e1c9-403c-a17b-0011ceec7d12
I had to remove the 3 day forecast for the time being since I need to do
some engineering to make it work with openweathermap.
Let me know if you have any errors, or lower-case weather.
I will push my current code up today. Also see if you can find the date
error. It only updates the dat on load.
On Thu, Jan 10, 2019, 2:31 AM PeterSumm ***@***.*** wrote:
> I loved this for about a week, but then Yahoo changed their API and it
> died. Before I jump into the code to try to fix it, is anyone working on
> this?
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#1>, or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AA8pt8YnaU0JVJwH6ywHJ_7FfaDJSA2Jks5vBuxagaJpZM4Z47uh
>
> .
>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<
#1 (comment)>,
or mute the thread<
https://github.com/notifications/unsubscribe-auth/AngjPmCvG0ICv708q_Z8RZeZhHa5eKvoks5vBx1sgaJpZM4Z47uh
>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA8pt-TehP4LIYRcbc0tI3t1hUggpEayks5vByTQgaJpZM4Z47uh>
.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#1 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AngjPrD0Uixy0fhMI2LbWC_nl4cfcuRtks5vBzANgaJpZM4Z47uh>.
cmspooner commented
New version is in github
…On Thu, Jan 10, 2019, 7:30 AM helmsd29505 ***@***.*** wrote:
That was actually suggested by open weather maps support team. But I’ll
check on that.
Thanks
Donald Helms
________________________________
From: Chris Spooner ***@***.***>
Sent: Thursday, January 10, 2019 07:20
To: cmspooner/ForecastTime
Cc: helmsd29505; Comment
Subject: Re: [cmspooner/ForecastTime] Weather is broken due to Yahoo
weather API changes (#1)
FYI l, Technically users providing Thier own key is against the tos for
most providers.
On Thu, Jan 10, 2019, 6:32 AM helmsd29505 ***@***.*** wrote:
> Chris
> I’ll install the new version and test some. I’ll let you know how it
goes.
> I’ve decided to take this opportunity to expand my watch
> face(ShmackAnalog). I’ve built a test run that I’m personally running. I
> went back through the weather and expanded the other options (dark sky,
> underground, and open weather). Currently I’m running hard coded key and
> open weather. Everything seems to be working well. (Thanks for the
> suggestion) The plan is to add option for user to choose which source
they
> want, and provide their own key. If I get this done soon I’ll see what I
> can do with the forecasting and I’ll send you my findings. Best of luck
to
> you.
>
> Donald Helms
>
> ________________________________
> From: Chris Spooner ***@***.***>
> Sent: Thursday, January 10, 2019 06:01
> To: cmspooner/ForecastTime
> Cc: Subscribed
> Subject: Re: [cmspooner/ForecastTime] Weather is broken due to Yahoo
> weather API changes (#1)
>
> I have a fix that I'm testing in the beta:
>
https://gam.fitbit.com/gallery/clock/aa2ef146-e1c9-403c-a17b-0011ceec7d12
>
> I had to remove the 3 day forecast for the time being since I need to do
> some engineering to make it work with openweathermap.
> Let me know if you have any errors, or lower-case weather.
>
> I will push my current code up today. Also see if you can find the date
> error. It only updates the dat on load.
>
> On Thu, Jan 10, 2019, 2:31 AM PeterSumm ***@***.*** wrote:
>
> > I loved this for about a week, but then Yahoo changed their API and it
> > died. Before I jump into the code to try to fix it, is anyone working
on
> > this?
> >
> > —
> > You are receiving this because you are subscribed to this thread.
> > Reply to this email directly, view it on GitHub
> > <#1>, or mute the
thread
> > <
>
https://github.com/notifications/unsubscribe-auth/AA8pt8YnaU0JVJwH6ywHJ_7FfaDJSA2Jks5vBuxagaJpZM4Z47uh
> >
> > .
> >
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub<
>
#1 (comment)
>,
> or mute the thread<
>
https://github.com/notifications/unsubscribe-auth/AngjPmCvG0ICv708q_Z8RZeZhHa5eKvoks5vBx1sgaJpZM4Z47uh
> >.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <
#1 (comment)
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AA8pt-TehP4LIYRcbc0tI3t1hUggpEayks5vByTQgaJpZM4Z47uh
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<
#1 (comment)>,
or mute the thread<
https://github.com/notifications/unsubscribe-auth/AngjPrD0Uixy0fhMI2LbWC_nl4cfcuRtks5vBzANgaJpZM4Z47uh
>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA8pt4Mig5UDdcurG6_tFA8TWLCu5VSAks5vBzJrgaJpZM4Z47uh>
.
nealkruis commented
I can confirm this is working on Versa.
cmspooner commented
New version up in github and on fitbit beta...forecast is back!
…On Thu, Jan 10, 2019 at 10:28 AM Neal Kruis ***@***.***> wrote:
I can confirm this is working on Versa.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA8pt8N6i4SZETc2YsxZ4yErEFxgNWbWks5vB1wkgaJpZM4Z47uh>
.
nealkruis commented
I'm not able to fetch weather data again on my versa. Did the API change again?
PeterSumm commented
Weather data is working for me.
The date still doesn't update at midnight but I can't see why.
cmspooner commented
It is an error I might have just finally fixed. It is incredibly hard to
test since I can only check things once a night.
…On Tue, Jan 15, 2019, 6:19 PM PeterSumm ***@***.*** wrote:
Weather data is working for me.
The date still doesn't update at midnight but I can't see why.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA8pt3xIwtv4dZkClF-XzjNvSafX5py1ks5vDmIQgaJpZM4Z47uh>
.
PeterSumm commented
OK, thanks. Let me know if I can help with testing. I'm in the +11:00 time zone, so if that's different from you then we may be able to test it twice a day between us.
cmspooner commented
Oooh... Good idea. I will contact you tomorrow if it isn't fixed.... I
think I have it figured out... But we'll see in 9 hours.
…On Tue, Jan 15, 2019, 7:12 PM PeterSumm ***@***.*** wrote:
OK, thanks. Let me know if I can help with testing. I'm in the +11:00 time
zone, so if that's different from you then we may be able to test it twice
a day between us.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA8pt6O5SgsvQnbK306E5rJn_GFDt6LEks5vDm5ugaJpZM4Z47uh>
.
PeterSumm commented
Any luck?
cmspooner commented
It switch all by itself for me last night!
…On Wed, Jan 16, 2019, 4:08 PM PeterSumm ***@***.*** wrote:
Any luck?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA8pt4k7beGMHOn-W_Sh_p4YtDB215I8ks5vD5TogaJpZM4Z47uh>
.
PeterSumm commented
OK, thanks. I'll watch out for the new code release.
What was the problem? Your code looked right to me.
BTW, I've rewritten my big font code so that it's an option in the settings, so that it works for both Versa and Ionic and so that I can reintegrate it with new releases easily. If you'd like to look at it, please let me know.
Cheers,
Peter
cmspooner commented
... A semicolon... Maybe? Found that the date formatter until was fine...
So I copied code from the settings change to the Clock update and the only
difference was a semicolon.
…On Wed, Jan 16, 2019, 5:47 PM PeterSumm ***@***.*** wrote:
OK, thanks. I'll watch out for the new code release.
What was the problem? Your code looked right to me.
BTW, I've rewritten my big font code so that it's an option in the
settings, so that it works for both Versa and Ionic and so that I can
reintegrate it with new releases easily. If you'd like to look at it,
please let me know.
Cheers,
Peter
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA8pt_tkSAgKU-Dv1LJZ0WJQAIkEwkxaks5vD6wJgaJpZM4Z47uh>
.
cmspooner commented
New code on github now
…On Wed, Jan 16, 2019, 5:59 PM Chris Spooner ***@***.*** wrote:
... A semicolon... Maybe? Found that the date formatter until was fine...
So I copied code from the settings change to the Clock update and the only
difference was a semicolon.
On Wed, Jan 16, 2019, 5:47 PM PeterSumm ***@***.*** wrote:
> OK, thanks. I'll watch out for the new code release.
>
> What was the problem? Your code looked right to me.
>
> BTW, I've rewritten my big font code so that it's an option in the
> settings, so that it works for both Versa and Ionic and so that I can
> reintegrate it with new releases easily. If you'd like to look at it,
> please let me know.
>
> Cheers,
>
> Peter
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#1 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AA8pt_tkSAgKU-Dv1LJZ0WJQAIkEwkxaks5vD6wJgaJpZM4Z47uh>
> .
>
PeterSumm commented
This seems to work on the Ionic, but on the Versa it gives the message:
[11:56:41 AM]Unhandled TypeError: Expected a function.
tempAndConditionLabel at app/index.js:329,7
drawError at app/index.js:301,1
messaging at common/weather/device.js:124,1
? at app/index.js:1133,1
fetchWeather at app/index.js:1227,1
and the weather icon and text are missing.
I can't see why and I've tried copying text between the relevant files and it hasn't helped.
cmspooner commented
Just found that...might be something that's been hiding; and causing some
of my issues...can you see if you can figure it out?
…On Wed, Jan 16, 2019 at 8:00 PM PeterSumm ***@***.***> wrote:
This seems to work on the Ionic, but on the Versa it gives the message:
[11:56:41 AM]Unhandled TypeError: Expected a function.
tempAndConditionLabel at app/index.js:329,7
drawError at app/index.js:301,1
messaging at common/weather/device.js:124,1
? at app/index.js:1133,1
fetchWeather at app/index.js:1227,1
and the weather icon and text are missing.
I can't see why and I've tried copying text between the relevant files and
it hasn't helped.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA8pt6NEfmUlu-bfBimpfWjwRpmT1aWXks5vD8sPgaJpZM4Z47uh>
.
cmspooner commented
If you have "Show when weather fetched" it throws that error and stops
calling fetchWeather()!!! I'm off to bed soon; but if you can track this
one down I owe you one!
…On Wed, Jan 16, 2019 at 8:06 PM Chris Spooner ***@***.***> wrote:
Just found that...might be something that's been hiding; and causing some
of my issues...can you see if you can figure it out?
On Wed, Jan 16, 2019 at 8:00 PM PeterSumm ***@***.***>
wrote:
> This seems to work on the Ionic, but on the Versa it gives the message:
>
> [11:56:41 AM]Unhandled TypeError: Expected a function.
> tempAndConditionLabel at app/index.js:329,7
> drawError at app/index.js:301,1
> messaging at common/weather/device.js:124,1
> ? at app/index.js:1133,1
> fetchWeather at app/index.js:1227,1
>
> and the weather icon and text are missing.
>
> I can't see why and I've tried copying text between the relevant files
> and it hasn't helped.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#1 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AA8pt6NEfmUlu-bfBimpfWjwRpmT1aWXks5vD8sPgaJpZM4Z47uh>
> .
>
cmspooner commented
Also having a comrade in arms is nice!
…On Wed, Jan 16, 2019 at 8:11 PM Chris Spooner ***@***.***> wrote:
If you have "Show when weather fetched" it throws that error and stops
calling fetchWeather()!!! I'm off to bed soon; but if you can track this
one down I owe you one!
On Wed, Jan 16, 2019 at 8:06 PM Chris Spooner ***@***.***> wrote:
> Just found that...might be something that's been hiding; and causing some
> of my issues...can you see if you can figure it out?
>
> On Wed, Jan 16, 2019 at 8:00 PM PeterSumm ***@***.***>
> wrote:
>
>> This seems to work on the Ionic, but on the Versa it gives the message:
>>
>> [11:56:41 AM]Unhandled TypeError: Expected a function.
>> tempAndConditionLabel at app/index.js:329,7
>> drawError at app/index.js:301,1
>> messaging at common/weather/device.js:124,1
>> ? at app/index.js:1133,1
>> fetchWeather at app/index.js:1227,1
>>
>> and the weather icon and text are missing.
>>
>> I can't see why and I've tried copying text between the relevant files
>> and it hasn't helped.
>>
>> —
>> You are receiving this because you commented.
>> Reply to this email directly, view it on GitHub
>> <#1 (comment)>,
>> or mute the thread
>> <https://github.com/notifications/unsubscribe-auth/AA8pt6NEfmUlu-bfBimpfWjwRpmT1aWXks5vD8sPgaJpZM4Z47uh>
>> .
>>
>
PeterSumm commented
I've spent an hour or so on this and the suddenly I couldn't reproduce the problem any more, even after reloading your code that had previously failed. I'll try it again later.
Most odd - the only thing I can think of that might have changed is the actual weather conditions and so the data that's being returned. Or it could be some ugly bug in Javascript.
BTW, is there a reason that you're using SDK 1?
PeterSumm commented
I can get the message
[5:01:21 PM]Unhandled TypeError: Expected a function.
? at app/index.js:1133,1
fetchWeather at app/index.js:241,1
and the weather icon doesn't show although it displays a temperature, condition and location. I can't see why, but I'll keep looking.
This looks to me like some random location in memory is being corrupted. Can Javascript do that?
cmspooner commented
I'm not sure about the memory location possibly. I think I'm just going to
remove the show fetch option since it is the culprit.
I never changed sdk target since I'm not using any of the new apis. Is
there a compelling reason to raise it?
…On Thu, Jan 17, 2019, 1:05 AM PeterSumm ***@***.*** wrote:
I can get the message
[5:01:21 PM]Unhandled TypeError: Expected a function.
? at app/index.js:1133,1
fetchWeather at app/index.js:241,1
and the weather icon doesn't show although it displays a temperature,
condition and location. I can't see why, but I'll keep looking.
This looks to me like some random location in memory is being corrupted.
Can Javascript do that?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA8pt5oPRd1vxnmICAcCdaxX_BZD0b1Sks5vEBKrgaJpZM4Z47uh>
.
PeterSumm commented
I'm not sure.
I find the fact that problems mysteriously come and go when we add or remove perfectly good code really troubling. But I've not a better suggestions, so yes, go for it.
Interestingly, the problem is also apparent in my version with the big font option added.
cmspooner commented
It is definitely something in the fetch weather code. Turn that on and it
fails!
I think memory corruption is unlucky considering it shows up in the
simulator...which is not an emulator.
…On Thu, Jan 17, 2019 at 7:38 AM PeterSumm ***@***.***> wrote:
I'm not sure.
I find the fact that problems mysteriously come and go when we add or
remove perfectly good code really troubling. But I've not a better
suggestions, so yes, go for it.
Interestingly, the problem is also apparent in my version with the big
font option added.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA8ptxVBE_HIO5QKxaRRfz6hch0LttGDks5vEG7dgaJpZM4Z47uh>
.
PeterSumm commented
Does this help at all?
cmspooner commented
I just removed the fetch option... It was part of a larger problem that I
made for myself when I initially put in the code for the second api call to
get the forecast.
I was looking at the "private" _provider attribute of the weather object to
figure out which info I was getting.... I knew it was a bad idea but just
wanted to get something out. There can be a delay getting the data back
from openweathermap and sometimes I would try to put the wrong data into
the wrong spot.
I just added a provider field the returned data so I don't have to guess
anymore.
Show fetch got confused when it made the second call... So I just removed
it and made sure the value is false.
…On Thu, Jan 17, 2019, 8:43 PM PeterSumm ***@***.*** wrote:
Does this help at all?
https://davidwalsh.name/fix-javascript-errors <http://url>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA8pt4qrTfs4oZ9K-PYOolzvQCMvcevEks5vESbPgaJpZM4Z47uh>
.