Require only one review for pull requests to the cnab-go library

Question

Require only one review for pull requests to the cnab-go library

Closed this issue 3 years ago · 9 comments

We are having a hard time lately getting pull request reviews in a reasonable amount of time. @vdice and I discussed this in today's CNAB meeting and would like to propose that we only require a single review in this repository (spec still gets 2 reviews).

Would the maintainers please reply with a +1 if you agree?

chris-crone commented 3 years ago

SGTM!

+1

scottbuckel commented 3 years ago

+1!

silvin-lubecki commented 3 years ago

LGTM 👍

Answer 1 · 2021-05-26T16:30:48.000Z

+1 - We have definitely done this in the past with other projects in order to fine-tune velocity. In this case, I think it is 💯 justified.

Answer 2 · 2021-05-26T21:44:33.000Z

@technosophos How many votes do you think we need to make the change? So far we have you, myself, Radu, and Vaughn voting in favor.

Answer 3 · 2021-05-26T21:48:10.000Z

I would imagine simple majority would do.

Answer 4 · 2021-05-26T21:55:03.000Z

Ok, there are 8 people in the codeowners file, so just 1 more to go! 🍿

Answer 5 · 2021-05-27T06:18:25.000Z

+1

…

On Wed, 26 May 2021, 22:55 Carolyn Van Slyck, ***@***.***> wrote: Assigned #258 <#258> to @glyn <https://github.com/glyn>. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#258 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAXF2IRRQAU5VGPQT77UPLTPVU2FANCNFSM45SNC5XA> .

Answer 6 · 2021-05-27T17:20:03.000Z

I'll update the GitHub settings to only require a single review. So say we all. Thanks everyone!