Inject tool validation summary page
Closed this issue · 8 comments
Is your feature request related to a problem? Please describe.
Validation summary (could combine with submission summary)
Describe the solution you'd like
- How many unknown, pass, warning, and error
- If possible, what is the most occurred error, which may lead to batch correction, e.g. add decimal degrees to the coordinate as units
- Validation summary is static, could be calculated after validation and will remain the same until data changes
- Should be modeled as a
validation.models
class - Should use the IMAGE-ValidationTool
image_validation.ValidationResult.ValidationResultColumn
to get information againt the most attribute failing - Should have a dedicated page (not a record in
SubmissionDetailView
) to represent data - Ideally we need to point this page with edit pages, or for the most common errors to bulk update, as described in #16
Describe alternatives you've considered
It could start with a descriptive record. Could add other functionalities with time. We could decide a minimal set of features of such isse for first milestone
Additional context
Steps required:
- Refactor
validation.helpers.ValidationSummary
using appropriate method - Define a validation status View
- Define models for validation reports
- prepare report after validation, as a part of validation (validation is not finished before report)
- test code for pages and methods defined
- Verify validation summary within reload submission condition
- Update all-count when validating submission
- Small refactoring to improve code readability
I think that we still should have information about validation in SubmissionDetailedView and from there we could have a link to validation summary page.
So it could be:
N. of Animals 26 (26 with issues in validation)
Agree. But we need to discuss how (when) this number is calculated
Another consideration: this number could change (hopefully in better) after validation is finished. Should this message has to be submitted with the real time updates?
Yes, sure. I am working on it right now!
Remember that this number is calculated on the fly when the page is loaded. Since it never changes after the validation, could be calculated once and stored somewhere. While doing this you could send the message as you did for the status and submission message. This is one thing we have to discuss.
Since it never changes after the validation
Only true when validation can only be called manually (i.e. clicking the validate button)
A related question: validate all records or only records have been changed? (after uploading a data file, all records are actually changed from not-existing to some value) @bunop
If validation is called by admin or with a periodic task, it will apply all the stuff executed when clicking validation (since the button call a task in background), report included. They are not different in concepts.
Validation is called on all objects: only modified objects which pass validation could be submitted, as defined here. Submitted objects which pass validation will keep the same status
And a new object (after loading) need to be validated before submission, as described by common statuses