[REQUEST] Update README example
pulgamecanica opened this issue · 1 comments
pulgamecanica commented
Hello Good day!
It bothers me that the example given on the README doesn't compiles straight away with -Wall -Werror & -Wextra
Even more because the recommended Makefile does indeed include this flags, so my proposal would be to fix it.
srcs/main.c:25:31: error: comparison of integer expressions of different signedness: ‘int32_t’ {aka ‘int’} and ‘uint32_t’ {aka ‘unsigned int’} [-Werror=sign-compare]
(for both the loops)srcs/main.c:23:25: error: unused parameter ‘param’ [-Werror=unused-parameter]
srcs/main.c:58:22: error: unused parameter ‘argc’ [-Werror=unused-parameter]
srcs/main.c:58:40: error: unused parameter ‘argv’ [-Werror=unused-parameter]
Solutions:
- use
uint32_t
instead ofint32_t
(void) param;
- & 4.
int main(void) {
If you allow me, I can submit a PR with this changes :D
Cheers, and keep it up, this library is Gold! 🏆
W2Wizard commented
If you allow me, I can submit a PR with this changes :D
By all means go right ahead and submit a PR, i'll merge it asap.